sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.37k stars 462 forks source link

Factorize code in Polynomials and Ore Polynomials #30054

Open xcaruso opened 4 years ago

xcaruso commented 4 years ago

After #29629, we propose to make the class Polynomial inherit from the abstract class SkewPolynomial (since a lot of codes is shared between these two classes and a normal polynomial is just a skew polynomial under the identity map).

Any comment?

CC: @tscrim

Component: algebra

Issue created by migration from https://trac.sagemath.org/ticket/30054

xcaruso commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-After #29629, we propose to make the Polynomial class should inherit from the abstract class SkewPolynomial (since a lot of codes is shared between these two classes and a normal polynomial is just a skew polynomial under the identity map).
+After #29629, we propose to make the class `Polynomial` inherit from the abstract class `SkewPolynomial` (since a lot of codes is shared between these two classes and a normal polynomial is just a skew polynomial under the identity map).

 Any comment?
mkoeppe commented 3 years ago
comment:3

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.