sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.33k stars 453 forks source link

Remove mentions of packages KASH and Macaulay2 from tutorials #30109

Closed dimpase closed 4 years ago

dimpase commented 4 years ago

These packages are long gone, yet

grep -R KASH src/doc
grep -R Macaulay src/doc

return hits such as Macaulay and KASH are Sage packages etc.

CC: @dimpase @embray @rana-aerea @jhpalmieri @slel

Component: documentation

Keywords: kash, macaulay2

Author: John Palmieri

Branch/Commit: 961242d

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30109

jhpalmieri commented 4 years ago
comment:1

We should also remove these from src/bin/sage (best to base on top of #29111 or wait until the next beta when it should be merged).

jhpalmieri commented 4 years ago
comment:2

In fact git grep -w -i kash . returns lots of hits which should be fixed.

slel commented 4 years ago

Changed keywords from none to kash, macaulay2

slel commented 4 years ago
comment:3

We no longer have SPKGs for them, but still have interfaces to them.

Our interfaces should still work if Sage finds them installed separately.

Macaulay2 and its interface certainly are maintained, not sure about Kash.

jhpalmieri commented 4 years ago
comment:4

I was thinking about removing all references to packages, e.g., commands like sage -i kash. Probably remove the doctests in tests/cmdline.py about kash. Certainly keep the interface files, but with a change in the instructions for how to install kash, at least. The instructions at the top of interfaces/macaulay2.py are not obviously out of date.

jhpalmieri commented 4 years ago
comment:5

I wonder if we should remove sage --kash and sage --M2. Anyway, here is a first draft. I tried to deal with translations, but I probably messed some up, I did Russian only partly, and I didn't do Japanese at all.

jhpalmieri commented 4 years ago

Branch: u/jhpalmieri/kash-out

jhpalmieri commented 4 years ago

Author: John Palmieri

jhpalmieri commented 4 years ago

New commits:

ed676c9trac 30109: remove mention of kash and Macaulay2 as Sage packages
jhpalmieri commented 4 years ago

Commit: ed676c9

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from ed676c9 to 961242d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

961242dtrac 30109: remove mention of kash and Macaulay2 as Sage packages
jhpalmieri commented 4 years ago
comment:9

I added a link to the kash web page (http://page.math.tu-berlin.de/~kant/kash.html), but that page says it hasn't been changed since 2008. So I'm not very confident that it will work, and the top of our file interfaces/kash.py says "It is not enough to just have KASH installed on your computer", whatever that means.

slel commented 4 years ago
comment:10

Hopefully a Japanese speaker can take care of the Japanese tutorial.

mkoeppe commented 4 years ago

Reviewer: Matthias Koeppe

mkoeppe commented 4 years ago
comment:11

Looks good to me. More refinements and translations can be done on follow-up tickets.

vbraun commented 4 years ago

Changed branch from u/jhpalmieri/kash-out to 961242d