sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 482 forks source link

nauty: Switch to autotoolized fork so that shared libraries can be built #30271

Open mkoeppe opened 4 years ago

mkoeppe commented 4 years ago

(split out from #27952).

The fork is at https://github.com/mkoeppe/nauty

Depends on #27952

CC: @w-bruns @tobihan

Component: packages: standard

Keywords: sd111

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/nauty__switch_to_autotoolized_fork_so_that_shared_libraries_can_be_built @ ba75940

Reviewer: https://github.com/mkoeppe/sage/actions/runs/205072095

Issue created by migration from https://trac.sagemath.org/ticket/30271

mkoeppe commented 4 years ago

Branch: u/mkoeppe/nauty__switch_to_autotoolized_fork_so_that_shared_libraries_can_be_built

mkoeppe commented 4 years ago

Commit: 9ebc487

mkoeppe commented 4 years ago
comment:2

As seen in https://github.com/Normaliz/Normaliz/runs/936924467, this needs more work:

  [nauty-2.7.1+ds+sage-2020-08-01]   /usr/bin/ld: cannot open linker script file ./nauty.map: No such file or directory
  [nauty-2.7.1+ds+sage-2020-08-01]   collect2: error: ld returned 1 exit status

New commits:

9ebc487build/pkgs/nauty: Switch to autotoolized fork
mkoeppe commented 4 years ago

Dependencies: #27952

mkoeppe commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-This is for #27952.
+(split out from #27952).

 The fork is at https://github.com/mkoeppe/nauty
mkoeppe commented 4 years ago
comment:3

(removing cc as requested)

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

6e9191abuild/pkgs/e_antic: Update to 0.1.8
a906db8Merge branch 't/30262/update_e_antic_to_0_1_8' into t/27952/normaliz
582c309build/pkgs/normaliz: Update to 3.8.7
13c0375build/pkgs/pynormaliz: Update to 2.12
027ef5fbuild/pkgs/pynormaliz: Fix upstream_url
0882611Merge tag '9.2.beta7' into t/30262/update_e_antic_to_0_1_8
071bfc7Merge branch 't/30262/update_e_antic_to_0_1_8' into t/27952/normaliz
f3e8fc2document far facet condition and add a doctest
3f2d872Merge tag '9.2.beta8' into t/27952/normaliz
ba75940Merge branch 't/27952/normaliz' into t/30271/nauty__switch_to_autotoolized_fork_so_that_shared_libraries_can_be_built
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 4 years ago

Changed commit from 9ebc487 to ba75940

mkoeppe commented 4 years ago

Author: Matthias Koeppe

mkoeppe commented 4 years ago

Reviewer: https://github.com/mkoeppe/sage/actions/runs/205072095

mkoeppe commented 4 years ago
comment:6

ubuntu-trusty-maximal (https://github.com/mkoeppe/sage/runs/974420086)

/sage/local/var/tmp/sage/build/nauty-2.7.1+ds+sage-2020-08-02/src/sumlines.c:1512: undefined reference to `__gmpz_init'
sumlines-sumlines.o: In function `add_one':
/sage/local/var/tmp/sage/build/nauty-2.7.1+ds+sage-2020-08-02/src/sumlines.c:677: undefined reference to `__gmpz_init_set'
/sage/local/var/tmp/sage/build/nauty-2.7.1+ds+sage-2020-08-02/src/sumlines.c:629: undefined reference to `__gmpz_add'
sumlines-sumlines.o: In function `scanline':
/sage/local/var/tmp/sage/build/nauty-2.7.1+ds+sage-2020-08-02/src/sumlines.c:961: undefined reference to `__gmpz_set_str'
sumlines-sumlines.o: In function `writeline':
/sage/local/var/tmp/sage/build/nauty-2.7.1+ds+sage-2020-08-02/src/sumlines.c:388: undefined reference to `__gmpz_out_str'
collect2: error: ld returned 1 exit status

Worked ok on ubuntu-bionic-maximal (https://github.com/mkoeppe/sage/runs/974420157)

mkoeppe commented 3 years ago
comment:9

@tobihan: https://github.com/mkoeppe/nauty continues the autotoolization of nauty that is done partially by the Debian package. This may be of interest to the Debian maintainers

mkoeppe commented 3 years ago

Changed keywords from none to sd111

mkoeppe commented 3 years ago
comment:11

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.