Closed mkoeppe closed 4 years ago
Last commit to burn the bridges :)
BooleanPolynomialRing_constructor
vs. BooleanPolynomialRing
looks a bit confusing
Replying to @mkoeppe:
BooleanPolynomialRing_constructor
vs.BooleanPolynomialRing
looks a bit confusing
Not my code, I am only the messenger. I certainly agree that this largely decade old code would need a good fleeing - apart from the trimming I already did on import. I assumed we could do it after merging it.
Sure, just trying to figure out what the high level interface is intended to be.
build/pkgs/sagelib/dependencies
still has sage_brial
Right. I remember thinking about that last night. Forgot to remove it. Will do in a few hours if no one beats me to it.
Branch pushed to git repo; I updated commit sha1. New commits:
02a5af1 | build/pkgs/sagelib/dependencies: Remove sage_brial |
Author: François Bissey
Replying to @kiwifb:
Replying to @mkoeppe:
BooleanPolynomialRing_constructor
vs.BooleanPolynomialRing
looks a bit confusingNot my code, I am only the messenger. I certainly agree that this largely decade old code would need a good fleeing - apart from the trimming I already did on import. I assumed we could do it after merging it.
Indeed, this is a known problem that needs some attention: #21892, #24748, possibly #27019, #23310, #23312, possibly #23311, #15223.
My idea is to scrap BooleanPolynomialRing_constructor
and just have BooleanPolynomialRing
be a UniqueRepresentation
object, possibly just being a subclass of the monoid algebra parent.
My idea was to merge this in 9.2 and work on improving things in 9.3. However, if you know exactly what to do, we can work on this now.
I think that is a better plan. I am too stretched for time right now to work on this.
Reviewer: Matthias Koeppe
I agree with this plan - it will also be a good basis for modularization work in 9.3
I am in the process of looking at adding some of the documentation from sage-brial to the sage documentation. At least to see how it looks like.
If you think that's not worth adding now, it is fine.
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
91fe5e1 | Fix doctest and docstring formatting |
Just a touch up. One doctest was commented out so I decided to enable it. Building documentation revealed formatting issues in docstrings. All in the same file.
I built the doc with some added files from brial and we definitely should keep that for later work. Individual files need sensible title blocks for a start.
Changed branch from public/merge_sage_brial to 91fe5e1
As discussed in #29369 and #28918.
CC: @kiwifb @orlitzky @tscrim
Component: packages: standard
Author: François Bissey
Branch/Commit:
91fe5e1
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/30332