search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.31k stars 450 forks source link

src/tox.ini: Add flake8 #30573

Open mkoeppe opened 3 years ago

mkoeppe commented 3 years ago

Depending on the results of the experiment in #30547 (full flake8 for skew_tableau.py, as an experiment), we may want to add and document flake8 as a linter.

CC: @fchapoton @tscrim @tobiasdiez

Component: doctest framework

Issue created by migration from https://trac.sagemath.org/ticket/30573

tobiasdiez commented 3 years ago
comment:1

I feel like the combination pycodestyle + pyright is superior to flake8 (which is essentially pycodestyle + pyflakes). At least in my tests pyright rightfully complained about things that were not detected by pyflakes. See also #30415.

fchapoton commented 3 years ago
comment:2

see https://sgoel.dev/posts/setting-up-flake8-for-cython/ for cython configuration

mkoeppe commented 3 years ago
comment:3

Thanks for the pointer. Doesn't quite look like a production-ready solution though...

mkoeppe commented 3 years ago
comment:5

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.