search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.4k stars 473 forks source link

few easy internet doctests failures to fix #30632

Closed seblabbe closed 4 years ago

seblabbe commented 4 years ago

With 9.2.beta13, the command

sage -tp --optional=sage,internet src/sage/misc/remote_file.py src/sage/databases/oeis.py src/sage/misc/package.py

gives

----------------------------------------------------------------------
sage -t --random-seed=0 src/sage/misc/remote_file.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/databases/oeis.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/misc/package.py  # 1 doctest failed
----------------------------------------------------------------------

Component: doctest coverage

Author: Sébastien Labbé

Branch/Commit: a442fa9

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/30632

seblabbe commented 4 years ago

Description changed:

--- 
+++ 
@@ -1,7 +1,7 @@
 With 9.2.beta13, the command

-$ sage -t --optional=sage,internet src/sage/misc/remote_file.py src/sage/databases/oeis.py src/sage/misc/package.py +sage -tp --optional=sage,internet src/sage/misc/remote_file.py src/sage/databases/oeis.py src/sage/misc/package.py

 gives
seblabbe commented 4 years ago

New commits:

a442fa930632: fixing internet doctest failures
seblabbe commented 4 years ago

Author: Sébastien Labbé

seblabbe commented 4 years ago

Branch: u/slabbe/30632

seblabbe commented 4 years ago

Commit: a442fa9

fchapoton commented 4 years ago
comment:3

ok, merci

fchapoton commented 4 years ago

Reviewer: Frédéric Chapoton

slel commented 4 years ago
comment:4

The "not pypi" url could be changed to

-        sage: pypi = 'http://this.is.not.pypi.com/'
+        sage: pypi = 'http://not-pypi.example.com/'

but the existing solution works fine.

Merci Sébastien pour la branche, et Frédéric pour le feu vert.

vbraun commented 4 years ago

Changed branch from u/slabbe/30632 to a442fa9