sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.4k stars 473 forks source link

some typos in rings/ and schemes/ #31068

Closed fchapoton closed 3 years ago

fchapoton commented 3 years ago

found using

sage --tox -e=codespell src/sage/rings/

CC: @slel

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 4562ac7

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/31068

fchapoton commented 3 years ago

Branch: u/chapoton/31068

fchapoton commented 3 years ago

New commits:

5a940a0bunch of typos in rings/ and schemes/
fchapoton commented 3 years ago

Commit: 5a940a0

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 5a940a0 to 7821234

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7821234some details
slel commented 3 years ago
comment:3

Some optional suggestions while we are at it, but they can wait too.

While fixing "ambiguous" spelling, also change capitalisation.

-            ValueError: Input is ambiguous: x as well as raw_element=42 are specified.
+            ValueError: input is ambiguous: x as well as raw_element=42 are specified.
...
-            raise ValueError('Input is ambiguous: '
+            raise ValueError('input is ambiguous: '

While fixing "guarentee" -> "guarantee", also fix "there is not" -> "there is no" and single or no backticks to double backticks.

-         - A tuple (a, b, c) which satisfies `a = b*f + c*g`. There
-           is not guarantee that a, b, and c are minimal.
+         - A tuple ``(a, b, c)`` which satisfies ``a = b*f + c*g``. There
+           is no guarantee that ``a``, ``b``, and ``c`` are minimal.

Mis-spelled "seperate" incorrectly fixed to "saperate", should be "separate".

-    We can represent the Berkovich projective line in two saperate ways:
+    We can represent the Berkovich projective line in two separate ways:

Fix "exceeds" as well as "allotted" (twice).

-        However, if the Newton iteration exceedes the allotted attempts,
+        However, if the Newton iteration exceeds the allotted attempts,

Finally, whenever touching % or .format(...) string formatting, I would go f-strings, but up to you since you're doing the work!

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e6fa6e6more fixes in rings and schemes
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 7821234 to e6fa6e6

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

4562ac7one more pyflakes fix
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from e6fa6e6 to 4562ac7

slel commented 3 years ago
comment:6

Positive review from me if bots are happy.

slel commented 3 years ago

Reviewer: Samuel Lelièvre

fchapoton commented 3 years ago
comment:7

ok, let's say that the bots are green enough

Merci Samuel

vbraun commented 3 years ago

Changed branch from u/chapoton/31068 to 4562ac7