Closed fchapoton closed 3 years ago
Branch: u/chapoton/31068
Branch pushed to git repo; I updated commit sha1. New commits:
7821234 | some details |
Some optional suggestions while we are at it, but they can wait too.
While fixing "ambiguous" spelling, also change capitalisation.
- ValueError: Input is ambiguous: x as well as raw_element=42 are specified.
+ ValueError: input is ambiguous: x as well as raw_element=42 are specified.
...
- raise ValueError('Input is ambiguous: '
+ raise ValueError('input is ambiguous: '
While fixing "guarentee" -> "guarantee", also fix "there is not" -> "there is no" and single or no backticks to double backticks.
- - A tuple (a, b, c) which satisfies `a = b*f + c*g`. There
- is not guarantee that a, b, and c are minimal.
+ - A tuple ``(a, b, c)`` which satisfies ``a = b*f + c*g``. There
+ is no guarantee that ``a``, ``b``, and ``c`` are minimal.
Mis-spelled "seperate" incorrectly fixed to "saperate", should be "separate".
- We can represent the Berkovich projective line in two saperate ways:
+ We can represent the Berkovich projective line in two separate ways:
Fix "exceeds" as well as "allotted" (twice).
- However, if the Newton iteration exceedes the allotted attempts,
+ However, if the Newton iteration exceeds the allotted attempts,
Finally, whenever touching %
or .format(...)
string formatting,
I would go f-strings, but up to you since you're doing the work!
Branch pushed to git repo; I updated commit sha1. New commits:
e6fa6e6 | more fixes in rings and schemes |
Branch pushed to git repo; I updated commit sha1. New commits:
4562ac7 | one more pyflakes fix |
Positive review from me if bots are happy.
Reviewer: Samuel Lelièvre
ok, let's say that the bots are green enough
Merci Samuel
Changed branch from u/chapoton/31068 to 4562ac7
found using
CC: @slel
Component: documentation
Author: Frédéric Chapoton
Branch/Commit:
4562ac7
Reviewer: Samuel Lelièvre
Issue created by migration from https://trac.sagemath.org/ticket/31068