sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.3k stars 447 forks source link

script packages for tk, python _tkinter module, update documentation #31206

Open mkoeppe opened 3 years ago

mkoeppe commented 3 years ago

We add script packages to keep track of system package information for Tcl/tk and the python _tkinter module

https://doc.sagemath.org/html/en/installation/source.html#tcl-tk

https://github.com/3-manifolds/fix_mac_sage/tree/master/fix_mac_sage9_2

https://www.tcl.tk/software/tcltk/download.html

https://github.com/python/cpython/blob/master/setup.py#L1814

System package info:

CC: @slel @dimpase @NathanDunfield @culler

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: u/mkoeppe/script_packages_for_tkpythontkinter_module__update_documentation @ ca1eaf8

Issue created by migration from https://trac.sagemath.org/ticket/31206

mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -2,4 +2,4 @@

 https://github.com/3-manifolds/fix_mac_sage/tree/master/fix_mac_sage9_2

-
+https://www.tcl.tk/software/tcltk/download.html
mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
+We add script packages to keep track of system package information for Tcl/tk and the python `_tkinter` module
+
 https://doc.sagemath.org/html/en/installation/source.html#tcl-tk

 https://github.com/3-manifolds/fix_mac_sage/tree/master/fix_mac_sage9_2
mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -5,3 +5,8 @@
 https://github.com/3-manifolds/fix_mac_sage/tree/master/fix_mac_sage9_2

 https://www.tcl.tk/software/tcltk/download.html
+
+https://repology.org/project/tcl/versions
+https://repology.org/project/tcl-tk/versions
+
+
mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -6,7 +6,9 @@

 https://www.tcl.tk/software/tcltk/download.html

-https://repology.org/project/tcl/versions
-https://repology.org/project/tcl-tk/versions
+System package info:
+- https://repology.org/project/tcl/versions
+- https://repology.org/project/tcl-tk/versions
+- https://repology.org/project/python3-tkinter/versions
mkoeppe commented 3 years ago

Branch: u/mkoeppe/script_packages_for_tkpythontkinter_module__update_documentation

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

5c05887build/pkgs/python3_tkinter/spkg-configure.m4: Fixup
89e9f5fbuild/pkgs/tcl_tk: New dummy script package
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Commit: 89e9f5f

mkoeppe commented 3 years ago

Description changed:

--- 
+++ 
@@ -6,6 +6,8 @@

 https://www.tcl.tk/software/tcltk/download.html

+https://github.com/python/cpython/blob/master/setup.py#L1814
+
 System package info:
 - https://repology.org/project/tcl/versions
 - https://repology.org/project/tcl-tk/versions
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4434f4abuild/pkgs/python3_tkinter: New dummy script package
067c3acbuild/pkgs/python3_tkinter/spkg-configure.m4: Fixup
ca1eaf8build/pkgs/tcl_tk: New dummy script package
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 89e9f5f to ca1eaf8

mkoeppe commented 3 years ago

Author: Matthias Koeppe

mkoeppe commented 3 years ago
comment:10

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

dimpase commented 1 year ago
comment:14

needs a rebase

dimpase commented 9 months ago

Do you think we need to proceed with this ticket? I'd rather see all this shipped to the system Python.

mkoeppe commented 9 months ago

Do you think we need to proceed with this ticket? I'd rather see all this shipped to the system Python.

That's exactly what the branch does. It only adds dummy packages with spkg-configure, not an installation script.

dimpase commented 9 months ago

This (that one can provide such a dummy package) equally applies to any Python package,not only to Tkinter. So, why bother with any packages not related to Sage?

mkoeppe commented 9 months ago

In #36719, you are adding ad-hoc instructions of what Debian packages to install for Tk. By creating a dummy package with system package information, this will be presented in a more uniform way.

dimpase commented 9 months ago

In #36719, you are adding ad-hoc instructions of what Debian packages to install for Tk. By creating a dummy package with system package information, this will be presented in a more uniform way.

I think our direction is to fully switch to using system Python, no? If so, such a package is obsolete, or will be.

mkoeppe commented 9 months ago

A dummy package is for providing system package information.

i.e. what system package has to be installed that provides Python with a working _tkinter module.

dimpase commented 9 months ago

Why do we care about a Python package which has no interactions with Sage?

mkoeppe commented 9 months ago

Snappy.

dimpase commented 9 months ago

let them worry about having a good for them Python

mkoeppe commented 9 months ago

That's too much "us vs them" for my taste, which is usually not helpful.