search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.37k stars 462 forks source link

Replace deprecated alias Polyhedron_base.affine_hull by a new method #31963

Closed mkoeppe closed 3 years ago

mkoeppe commented 3 years ago

29326, renaming affine_hull to affine_hull_projection, was merged in 9.1 (released May 21, 2020).

We replace this alias by a new method affine_hull that ... computes the affine hull as a polyhedron defined by just the equations. This will conform to the ABC for convex sets (#31919)

As a courtesy, if unknown keyword arguments are passed, we point users to the renamed method.

Depends on #29811

CC: @kliem @jplab @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: dfbd801

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31963

mkoeppe commented 3 years ago

Branch: u/mkoeppe/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method

mkoeppe commented 3 years ago

Changed dependencies from #31919 to #31919, #29811

mkoeppe commented 3 years ago

Commit: d37c710

mkoeppe commented 3 years ago

Last 10 new commits:

9a7ce3asrc/sage/geometry/convex_set.py: More examples and tests
e2b0ef7ConvexSet_base._test_convex_set: Fix doctest output
45c840aConvexSet_base.codim, codimension: New
17467c4ConvexSet_base: Make dimension, ambient_dimension aliases for dim, ambient_dim
fa5dc6eConvexSet_base.cartesian_product: New
f4bdffdConvexSet_base.contains, intersection: New
465b0cbMerge #31919
5965400PolyhedronFace.affine_tangent_cone: New
3f13401Merge #29811
d37c710Polyhedron_base.affine_hull: New, replace deprecated alias for affine_hull_projection
mkoeppe commented 3 years ago

Author: Matthias Koeppe

mkoeppe commented 3 years ago

Changed dependencies from #31919, #29811 to #29811

kliem commented 3 years ago
comment:4

You should add the method to the polyhedron quickref in docs.

Otherwise it's good to go. Had a green bot weeks ago and everything still works.

kliem commented 3 years ago

Reviewer: Jonathan Kliem

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from d37c710 to dfbd801

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

314e46aMerge tag '9.4.beta4' into t/31963/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method
dfbd801src/doc/en/thematic_tutorials/geometry/polyhedra_quickref.rst: Add affine_hull
mkoeppe commented 3 years ago
comment:7

Thanks!

vbraun commented 3 years ago

Changed branch from u/mkoeppe/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method to dfbd801