Deprecate sage.misc.misc.union

[mkoeppe]

We have a global binding of union that returns "the union of x and y, as a list". We deprecate it because this is an outdated interface (with strong "early Python" vibes) and not suitable for the global namespace. It is only used in a few places in the Sage library. (There is no intersection.)

Depends on #32140

CC: @tscrim @jhpalmieri

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 699f05b

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/32096

[mkoeppe]

Branch: u/mkoeppe/deprecate_sage_misc_misc_union

[mkoeppe]

comment:2

There are 3 more uses that I haven't fixed yet

---

New commits:

00e6c45

sage.misc.misc.union: Deprecate, remove uses

[mkoeppe]

Commit: 00e6c45

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Changed commit from 00e6c45 to 6d5ec17

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Branch pushed to git repo; I updated commit sha1. New commits:

cd42cf7	src/sage/schemes/elliptic_curves/ell_number_field.py: Remove useless use of union
6d5ec17	src/sage/topology/simplicial_complex.py: Remove use of sage.misc.misc.union

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-We have a global binding of `union` that returns "the union of x and y, as a list". We deprecate it because this is an outdated interface and not suitable for the global namespace. It is only used in a few places in the Sage library. (There is no `intersection`.)
+We have a global binding of `union` that returns "the union of x and y, as a list". We deprecate it because this is an outdated interface (with strong "early Python" vibes) and not suitable for the global namespace. It is only used in a few places in the Sage library. (There is no `intersection`.)

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7eee760	sage.misc.misc.union: Deprecate, remove uses
44da7d8	src/sage/schemes/elliptic_curves/ell_number_field.py: Remove useless use of union
8fb8315	src/sage/topology/simplicial_complex.py: Remove use of sage.misc.misc.union

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Changed commit from 6d5ec17 to 8fb8315

[jhpalmieri]

comment:6

I'm getting doctest failures because of the deprecation warning:

sage -t --long --warn-long 98.0 --random-seed=0 src/sage/groups/perm_gps/permgroup.py  # 1 doctest failed
sage -t --long --warn-long 98.0 --random-seed=0 src/sage/arith/misc.py  # 1 doctest failed
sage -t --long --warn-long 98.0 --random-seed=0 src/sage/geometry/polyhedron/library.py  # 1 doctest failed

[jhpalmieri]

comment:7

The changes look okay, though.

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Branch pushed to git repo; I updated commit sha1. New commits:

bfddaae

Remove uses of sage.misc.misc.union in doctests

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Changed commit from 8fb8315 to bfddaae

[mkoeppe]

comment:9

Thanks for testing! I forgot to look for those

[jhpalmieri]

Reviewer: John Palmieri

[jhpalmieri]

comment:10

Looks good to me.

[mkoeppe]

comment:11

Thanks!

[vbraun]

comment:12

    STDOUT: CONFLICT (content): Merge conflict in src/sage/schemes/elliptic_curves/ell_rational_field.py

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Branch pushed to git repo; I updated commit sha1. New commits:

149aa32	Some cleanup of padic documentation.
8e2b0a0	Merge branch 'develop' into public/documentation/fix_escape_seq-32140
0be7871	Some last little details.
93659db	Doing some additional cleanup and normalization of documentation and errors.
2b2e7bf	Fixing two other doctest failures in other files from error message changes.
3a30f30	Fixing docstrings in ell_rational_field.py.
460e70c	Some spelling errors and removed misplaced / character.
699f05b	Merge #32140

[7ed8c4ca-6d56-4ae9-953a-41e42b4ed313]

Changed commit from bfddaae to 699f05b

[mkoeppe]

Dependencies: #32140

[mkoeppe]

comment:14

Merged #32140 to resolve merge conflict

[vbraun]

Changed branch from u/mkoeppe/deprecate_sage_misc_misc_union to 699f05b