Closed mkoeppe closed 2 years ago
Branch pushed to git repo; I updated commit sha1. New commits:
ac46936 | build/pkgs/flint/spkg-install.in: Use cmake |
Branch pushed to git repo; I updated commit sha1. New commits:
9ea2e5c | build/pkgs/arb/patches: Add https://github.com/fredrik-johansson/arb/commit/b6c8032e2da1b19eb7c5a5f5c2f3372643e3d170 |
After switching to the cmake
build system:
Failure on ubuntu-trusty-standard
(where Sage rejects system ntl
), likely because FLINT accepts system NTL:
-- Detecting CXX compile features - done
-- Found GMP: /usr/include/x86_64-linux-gnu (Required is at least version "6.0.0")
-- Found MPFR: /usr/include (Required is at least version "1.0.0")
-- Found NTL: /usr/lib/libntl.so
-- Found PythonInterp: /usr/bin/python (found version "2.7.6")
-- Found CBLAS: /usr/include
...
lib/libflint.so.16.1.0: undefined reference to `_ntl_gscompare(_ntl_gbigint_body*, long)'
lib/libflint.so.16.1.0: undefined reference to `_ntl_gmod(_ntl_gbigint_body*, _ntl_gbigint_body*, _ntl_gbigint_body**)'
lib/libflint.so.16.1.0: undefined reference to `_ntl_gfree(_ntl_gbigint_body*)'
lib/libflint.so.16.1.0: undefined reference to `_ntl_gsetlength(_ntl_gbigint_body**, long)'
lib/libflint.so.16.1.0: undefined reference to `mpfr_rootn_ui'
lib/libflint.so.16.1.0: undefined reference to `NTL::TerminalError(char const*)'
collect2: error: ld returned 1 exit status
make[5]: *** [bin/test-t-umul_ppmm] Error 1
(ubuntu-trusty-minimal
, i.e., without installation of system ntl
, is OK)
Likewise ubuntu-xenial
, debian-jessie
, debian-stretch
, etc.
Description changed:
---
+++
@@ -1 +1,4 @@
+
+https://arblib.org/history.html#version-2-20-0
+
Description changed:
---
+++
@@ -1,4 +1,4 @@
-https://arblib.org/history.html#version-2-20-0
+https://arblib.org/history.html
Changed dependencies from #32175 to #32175 #32567
Description changed:
---
+++
@@ -1,4 +1,4 @@
-
+https://groups.google.com/g/sage-devel/c/VdIl7NvcJbQ/m/JVJ3E9WrAAAJ
https://arblib.org/history.html
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1039613405 to none
Description changed:
---
+++
@@ -1,4 +1,8 @@
-https://groups.google.com/g/sage-devel/c/VdIl7NvcJbQ/m/JVJ3E9WrAAAJ
+FLINT 2.8.1 and FLINT 2.8.2 announced:
-https://arblib.org/history.html
+- https://groups.google.com/g/sage-devel/c/VdIl7NvcJbQ/m/JVJ3E9WrAAAJ
+Arb release history:
+
+- https://arblib.org/history.html
+
Flint 2.8.3 is out, please update.
Description changed:
---
+++
@@ -6,3 +6,4 @@
- https://arblib.org/history.html
+Upgrading FLINT will require using unreleased changes in Singular
Description changed:
---
+++
@@ -1,6 +1,7 @@
-FLINT 2.8.1 and FLINT 2.8.2 announced:
+FLINT 2.8.1 and FLINT 2.8.2 announced, then FLINT 2.8.3:
-- https://groups.google.com/g/sage-devel/c/VdIl7NvcJbQ/m/JVJ3E9WrAAAJ
+- https://groups.google.com/g/sage-devel/c/VdIl7NvcJbQ
+- https://groups.google.com/g/sage-devel/c/YAXRi9r13b0
Arb release history:
Changed keywords from none to upgrade, arb, flint
Description changed:
---
+++
@@ -1,10 +1,13 @@
-FLINT 2.8.1 and FLINT 2.8.2 announced, then FLINT 2.8.3:
+FLINT 2.8.1 and FLINT 2.8.2 announced, then FLINT 2.8.3,
+then FLINT 2.8.4:
- https://groups.google.com/g/sage-devel/c/VdIl7NvcJbQ
- https://groups.google.com/g/sage-devel/c/YAXRi9r13b0
+- https://groups.google.com/g/sage-devel/c/8UX7uniBb5E
Arb release history:
- https://arblib.org/history.html
-Upgrading FLINT will require using unreleased changes in Singular
+Upgrading FLINT will require using unreleased changes
+in Singular.
Replying to @mkoeppe:
After switching to the
cmake
build system:Failure on
ubuntu-trusty-standard
(where Sage rejects systemntl
), likely because FLINT accepts system NTL:-- Detecting CXX compile features - done -- Found GMP: /usr/include/x86_64-linux-gnu (Required is at least version "6.0.0") -- Found MPFR: /usr/include (Required is at least version "1.0.0") -- Found NTL: /usr/lib/libntl.so -- Found PythonInterp: /usr/bin/python (found version "2.7.6") -- Found CBLAS: /usr/include ... lib/libflint.so.16.1.0: undefined reference to `_ntl_gscompare(_ntl_gbigint_body*, long)' lib/libflint.so.16.1.0: undefined reference to `_ntl_gmod(_ntl_gbigint_body*, _ntl_gbigint_body*, _ntl_gbigint_body**)' lib/libflint.so.16.1.0: undefined reference to `_ntl_gfree(_ntl_gbigint_body*)' lib/libflint.so.16.1.0: undefined reference to `_ntl_gsetlength(_ntl_gbigint_body**, long)' lib/libflint.so.16.1.0: undefined reference to `mpfr_rootn_ui' lib/libflint.so.16.1.0: undefined reference to `NTL::TerminalError(char const*)' collect2: error: ld returned 1 exit status make[5]: *** [bin/test-t-umul_ppmm] Error 1
(
ubuntu-trusty-minimal
, i.e., without installation of systemntl
, is OK)Likewise
ubuntu-xenial
,debian-jessie
,debian-stretch
, etc.
According to CMake/FindNTL.cmake
it accepts hints, namely by setting $ENV{NTLDIR}
. It seems the same holds for the other packages.
Changed branch from u/mkoeppe/test_ticket__upgrade_flint_to_2_8_0 to u/gh-kliem/flint_2_8_4
What are these "unreleased changes in Singular"?
Either these should be a Singular patch, or this should be removed in the ticket description.
Works locally for me, however I had to distclean.
Branch pushed to git repo; I updated commit sha1. New commits:
1e16b3b | push minimal cmake version |
Are we upgrading arb here, too?
Replying to @dimpase:
Either these should be a Singular patch, or this should be removed in the ticket description.
They have just tagged Release-4-2-1p2
. "update for using FLINT 2.8.x" is a News item there, I don't know the details. We should probably do this update
I've opened #32907 for the Singular upgrade
Looks like we need to push the minimal version of NTL required, I'm not sure what is needed here:
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `_ntl_gscompare(_ntl_gbigint_body*, long)'
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `_ntl_gmod(_ntl_gbigint_body*, _ntl_gbigint_body*, _ntl_gbigint_body**)'
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `_ntl_gfree(_ntl_gbigint_body*)'
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `_ntl_gsetlength(_ntl_gbigint_body**, long)'
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `mpfr_rootn_ui'
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `NTL::TerminalError(char const*)'
And similar other failures.
Centos complains about:
[flint-2.8.4] make[5]: *** [CMakeFiles/fq_nmod_poly_factor-test-t-iterated_frobenius_preinv.dir/build.make:103: bin/fq_nmod_poly_factor-test-t-iterated_frobenius_preinv] Error 1
[flint-2.8.4] make[5]: Target 'CMakeFiles/fq_nmod_poly_factor-test-t-iterated_frobenius_preinv.dir/build' not remade because of errors.
[flint-2.8.4] make[4]: *** [CMakeFiles/Makefile2:63248: CMakeFiles/fq_nmod_poly_factor-test-t-iterated_frobenius_preinv.dir/all] Error 2
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `mpfr_rootn_ui'
[flint-2.8.4] collect2: error: ld returned 1 exit status
[flint-2.8.4] make[5]: *** [CMakeFiles/fq_poly-test-t-powmod_fmpz_binexp_preinv.dir/build.make:103: bin/fq_poly-test-t-powmod_fmpz_binexp_preinv] Error 1
[flint-2.8.4] make[5]: Target 'CMakeFiles/fq_poly-test-t-powmod_fmpz_binexp_preinv.dir/build' not remade because of errors.
[flint-2.8.4] make[4]: *** [CMakeFiles/Makefile2:63221: CMakeFiles/fq_poly-test-t-powmod_fmpz_binexp_preinv.dir/all] Error 2
[flint-2.8.4] lib/libflint.so.16.1.4: undefined reference to `mpfr_rootn_ui'
Apparently centos has an old version of mpfr.
Replying to @kliem:
Replying to @mkoeppe:
After switching to the
cmake
build system:Failure on
ubuntu-trusty-standard
(where Sage rejects systemntl
), likely because FLINT accepts system NTL:-- Detecting CXX compile features - done -- Found GMP: /usr/include/x86_64-linux-gnu (Required is at least version "6.0.0") -- Found MPFR: /usr/include (Required is at least version "1.0.0") -- Found NTL: /usr/lib/libntl.so -- Found PythonInterp: /usr/bin/python (found version "2.7.6") -- Found CBLAS: /usr/include ... lib/libflint.so.16.1.0: undefined reference to `_ntl_gscompare(_ntl_gbigint_body*, long)' lib/libflint.so.16.1.0: undefined reference to `_ntl_gmod(_ntl_gbigint_body*, _ntl_gbigint_body*, _ntl_gbigint_body**)' lib/libflint.so.16.1.0: undefined reference to `_ntl_gfree(_ntl_gbigint_body*)' lib/libflint.so.16.1.0: undefined reference to `_ntl_gsetlength(_ntl_gbigint_body**, long)' lib/libflint.so.16.1.0: undefined reference to `mpfr_rootn_ui' lib/libflint.so.16.1.0: undefined reference to `NTL::TerminalError(char const*)' collect2: error: ld returned 1 exit status make[5]: *** [bin/test-t-umul_ppmm] Error 1
(
ubuntu-trusty-minimal
, i.e., without installation of systemntl
, is OK)Likewise
ubuntu-xenial
,debian-jessie
,debian-stretch
, etc.According to
CMake/FindNTL.cmake
it accepts hints, namely by setting$ENV{NTLDIR}
. It seems the same holds for the other packages.
Ok, I really don't know how this works with cmake.
E.g. with mpfr flint does:
find_path(MPFR_INCLUDE_DIRS NAMES mpfr.h PATHS $ENV{GMPDIR} $ENV{MPFRDIR} ${INCLUDE_INSTALL_DIR})
Branch pushed to git repo; I updated commit sha1. New commits:
da45eb1 | use autotools instead of cmake |
Changed dependencies from #32175 #32567 to #32175 #32567, #32907
Somehow make build
after upgrading or downgrading flint doesn't work:
File "sage/rings/polynomial/polynomial_element.pyx", line 67, in init sage.rings.polynomial.polynomial_element (build/cythonized/sage/rings/polynomial/polynomial_element.c:107015)
File "/srv/public/kliem/sage/local/var/lib/sage/venv-python3.7/lib/python3.7/site-packages/sage/rings/polynomial/polynomial_ring.py", line 154, in <module>
import sage.rings.polynomial.polynomial_element_generic as polynomial_element_generic
File "/srv/public/kliem/sage/local/var/lib/sage/venv-python3.7/lib/python3.7/site-packages/sage/rings/polynomial/polynomial_element_generic.py", line 1556, in <module>
from sage.rings.polynomial.polynomial_rational_flint import Polynomial_rational_flint
ImportError: libflint.so.16: cannot open shared object file: No such file or directory
Running make build-clean
helped.
Needs rebasing.
Take the opportunity to upgrade to Arb 2.22.1?
Yes, that's probably a good idea
Changed branch from u/gh-kliem/flint_2_8_4 to u/mkoeppe/flint_2_8_4
Changed branch from u/mkoeppe/flint_2_8_4 to u/gh-kliem/flint_2_8_4
Changed reviewer from https://github.com/kliem/sage/pull/49/checks to none
Changed branch from u/gh-kliem/flint_2_8_4 to u/mkoeppe/flint_2_8_4
Changed dependencies from #32175 #32567, #32907 to none
FLINT 2.8.1 and FLINT 2.8.2 announced, then FLINT 2.8.3, then FLINT 2.8.4:
Arb release history:
Depends on #33189
CC: @slel
Component: packages: standard
Keywords: upgrade, arb, flint
Author: Jonathan Kliem, Matthias Koeppe
Branch/Commit:
45f4984
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/32211