sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.34k stars 454 forks source link

Fix use of MixedIntegerLinearProgram in sage.graphs.domination #32224

Closed dcoudert closed 3 years ago

dcoudert commented 3 years ago

Part of #32191 (Meta-ticket: Audit/fix all uses of MixedIntegerLinearProgram in sage.combinat, sage.graphs).

Depends on #32197

Component: graph theory

Author: David Coudert

Branch/Commit: e99fad4

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32224

dcoudert commented 3 years ago

Commit: e99fad4

dcoudert commented 3 years ago

Last 10 new commits:

3dca4e9MixedIntegerLinearProgram.get_values: If convert=True, convert real variables from float to base_ring
9ad3fa8MixedIntegerLinearProgram.get_converted_values; subsumed by get_values
f62a777src/sage/numerical/mip.pyx: Remove unused imports
cfd8c7btrac #32197: remove another useless import
cf16293MixedIntegerLinearProgram.get_values: Fix up for tolerance=None
5a74113MixedIntegerLinearProgram._backend_variable_value: Add docstring
aa4eed5MixedIntegerLinearProgram._backend_variable_value*: Add docstrings, examples
00b34aatrac #32197: review commit
db83853trac #32197: another review commit
e99fad4trac #32224: Fix use of MixedIntegerLinearProgram in sage.graphs.domination
dcoudert commented 3 years ago

Branch: public/graphs/32224_domination

dcoudert commented 3 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Part of #32191 (Meta-ticket: Audit/fix all uses of MixedIntegerLinearProgram?? in sage.combinat, sage.graphs).
+Part of #32191 (Meta-ticket: Audit/fix all uses of `MixedIntegerLinearProgram` in sage.combinat, sage.graphs).
mkoeppe commented 3 years ago

Reviewer: Matthias Koeppe

dcoudert commented 3 years ago

Dependencies: #32197

vbraun commented 3 years ago

Changed branch from public/graphs/32224_domination to e99fad4