sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.36k stars 462 forks source link

cysignals: Replace compile-time dependency on pari by run-time dispatch #32431

Open mkoeppe opened 3 years ago

mkoeppe commented 3 years ago

Upstream issue:

https://github.com/sagemath/cysignals/issues/125

CC: @kliem @tscrim @videlec @dimpase

Component: packages: standard

Work Issues: cypari2 and cysignals need new releases

Author: Jonathan Kliem

Branch/Commit: public/32431 @ 0353619

Issue created by migration from https://trac.sagemath.org/ticket/32431

kliem commented 3 years ago
comment:2

See https://github.com/sagemath/cysignals/pull/149.

Seems to work for me (when adding

# distutils: libraries = pari

to cypari2/types.pxd.

kliem commented 3 years ago
comment:3

But currently cysignals own tests are failing. Will see tomorrow what is going on.

kliem commented 3 years ago

Author: Jonathan Kliem

kliem commented 3 years ago
comment:4

It looks like this can be solved with

https://github.com/sagemath/cysignals/pull/149

and

https://github.com/sagemath/cypari2/pull/108.


New commits:

cee84d1Replace compile-time dependency on pari by run-time dispatch
kliem commented 3 years ago

Work Issues: cypari2 and cysignals need new releases

kliem commented 3 years ago

Branch: public/32431

kliem commented 3 years ago

Commit: cee84d1

kliem commented 3 years ago

Attachment: cypari2-2.1.3b1.tar.gz

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago
comment:5

Attachment: cysignals-1.11.0a0.dev0.tar.gz

Branch pushed to git repo; I updated commit sha1. New commits:

8c91984updated function signatures
0c81e31add doctests that confirms that cysignals interfaces the PARI signals
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from cee84d1 to 0c81e31

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

0353619fixed merge conflict
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 0c81e31 to 0353619

mkoeppe commented 1 year ago
comment:12

What's the status here?