Closed mkoeppe closed 2 years ago
Last 10 new commits:
7094aab | sage.geometry.polyedron.combinatorial_polyhedron: Mark more doctests # optional - sage.combinat |
7ff2f74 | src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Some more # optional |
6baf055 | src/sage/geometry/polyhedron/base.py: Some more # optional |
7c73a01 | src/sage/geometry/polyhedron/base.py: Some more # optional |
5a3dbf4 | src/sage/geometry/polyhedron/combinatorial_polyhedron/face_iterator.pyx: Mark doctests # optional - sage.rings.number_field or sage.combinat |
e236b52 | src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: More # optional |
d892e34 | git grep -l 'sage:.*plot' src/sage/geometry/ | xargs sed -i.bak '/sage: .*plot(/s/$/ # optional - sage.plot/' |
2fd3fdf | src/sage/geometry/polyhedron/combinatorial_polyhedron/list_of_faces.pyx: Add '# optional - sage.combinat' for tests using combinatorial examples |
59246d4 | src/sage/geometry/polyhedron/representation.py: Add '# optional - sage.rings.number_field' in doctests |
03ea96d | src/sage/geometry/polyhedron/backend_polymake.py: Add # optional - sage.rings.number_field |
Author: Matthias Koeppe
Branch pushed to git repo; I updated commit sha1. New commits:
c97428e | src/sage/geometry/polyhedron/combinatorial_polyhedron/combinatorial_face.pyx: fix typo |
Description changed:
---
+++
@@ -1 +1 @@
-
+cherry-picked from #32432
Reviewer: Dima Pasechnik
lgtm
Thanks!
Except the patchbot indicates some failures
Branch pushed to git repo; I updated commit sha1. New commits:
d77eb85 | sage.geometry: Add missing # optional tags |
But there's something else wrong:
The log indicates
Using --optional=argcomplete,build,ccache,debian,dochtml,pip,sage,sage.rings.real_double,sage_spkg
... lots of the components such as sage.plot
are missing
Description changed:
---
+++
@@ -1 +1,3 @@
-cherry-picked from #32432
+cherry-picked from #32432.
+
+We also fix up `sage.features.sagemath`.
Branch pushed to git repo; I updated commit sha1. New commits:
f32b992 | src/sage/features/sagemath.py (sage.combinat): Fix the name of the tested PythonModule |
With the new diagnostic messages issued with sage -t --verbose
, we see:
FeatureTestResult('sage.combinat.combination', False), reason: Failed to import `sage.combinat.combination`: cannot import name complex_mpfr
FeatureTestResult('sage.graphs.graph', False), reason: Failed to import `sage.graphs.graph`: cannot import name complex_mpfr
FeatureTestResult('sage.plot.plot', False), reason: Failed to import `sage.plot.plot`: cannot import name complex_mpfr
FeatureTestResult('sage.rings.number_field.number_field_element', False), reason: Failed to import `sage.rings.number_field.number_field_element`: cannot import name complex_mpfr
FeatureTestResult('sage.rings.real_double', True), reason: Successfully imported `sage.rings.real_double`.
FeatureTestResult('sage.symbolic.expression', False), reason: Failed to import `sage.symbolic.expression`: cannot import name complex_mpfr
So some cyclic import business is happening here
Fixing the imports, or alternatively running the sagemath feature tests after sage.all has been imported, will be done in a follow-up ticket.
Let's see what the patchbot says now.
Branch pushed to git repo; I updated commit sha1. New commits:
30eee2e | src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Add another missing # optional - sage.plot |
Branch pushed to git repo; I updated commit sha1. New commits:
c1b1d93 | src/sage/geometry/polyhedron/plot.py: Add more # optional - sage.plot |
Branch pushed to git repo; I updated commit sha1. New commits:
eb31b22 | src/sage/geometry/voronoi_diagram.py: Add # optional - sage.rings.number_field |
d1b3bca | src/sage/geometry/integral_points.pyx: Add # optional - sage.rings.number_field |
98522e0 | src/sage/numerical: Add # optional - sage.rings.number_field |
Branch pushed to git repo; I updated commit sha1. New commits:
b846c0a | src/sage/numerical/backends/interactivelp_backend.pyx: Add missing # optional |
lgtm
Thanks!
Is there a ticket to fix the imports already? Lots of tests are being skipped in beta6 because of this.
Changed commit from b846c0a
to none
Help is welcome on tickets
cherry-picked from #32432.
We also fix up
sage.features.sagemath
.CC: @kliem
Component: refactoring
Author: Matthias Koeppe
Branch:
b846c0a
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/32732