sage.geometry: More # optional

mkoeppe commented 3 years ago

Depends on #32776 Depends on #32732 Depends on #32174 Depends on #32889

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 1c028c7

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32846

mkoeppe commented 3 years ago

Dependencies: #32776

mkoeppe commented 3 years ago

Branch: u/mkoeppe/sage_geometry_polyhedron__more___optional

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`8085729`	`src/sage/geometry: Mark more doctests # optional - sage.rings.number_field`
`0c5ed4c`	`src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst: Add # optional - sage.rings.number_field, sage.symbolic`
`89267f8`	`src/sage/geometry/polyhedron/backend_normaliz.py: Add more # optional - sage.rings.number_field`
`ebe5d22`	`src/sage/geometry/polyhedron/base.py: Add more # optional - sage.rings.number_field`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Commit: ebe5d22

mkoeppe commented 3 years ago

Author: Matthias Koeppe

mkoeppe commented 3 years ago

Changed dependencies from #32776 to #32776, #32732

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from ebe5d22 to df22260

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`f32b992`	`src/sage/features/sagemath.py (sage.combinat): Fix the name of the tested PythonModule`
`30eee2e`	`src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Add another missing # optional - sage.plot`
`c1b1d93`	`src/sage/geometry/polyhedron/plot.py: Add more # optional - sage.plot`
`eb31b22`	`src/sage/geometry/voronoi_diagram.py: Add # optional - sage.rings.number_field`
`d1b3bca`	`src/sage/geometry/integral_points.pyx: Add # optional - sage.rings.number_field`
`98522e0`	`src/sage/numerical: Add # optional - sage.rings.number_field`
`b846c0a`	`src/sage/numerical/backends/interactivelp_backend.pyx: Add missing # optional`
`94999bc`	`Merge #32732`
`a36005e`	`src/sage/geometry/polyhedron/parent.py: Add # optional - sage.rings.number_field`
`df22260`	`src/sage/geometry/polyhedron/library.py: Add # optional - sage.rings.number_field`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`5d54e67`	`src/sage/geometry/polyhedron/base.py: Add more # optional - sage.graphs, sage.combinat, sage.rings.number_field`
`47c97cc`	`src/sage/geometry/polyhedron/base.py: Add # optional - sage.plot`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from df22260 to 47c97cc

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 47c97cc to 5e1df0d

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`148dad2`	`src/sage/geometry/polyhedron/base.py: Add missing # optional - sage.rings.number_field`
`5e1df0d`	`src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst: Add missing # optional - sage.rings.number_field`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Changed commit from 5e1df0d to 44f15a0

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 3 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

44f15a0 Merge tag '9.5.beta6' into t/32846/sage_geometry_polyhedron__more___optional

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 44f15a0 to 38ff15b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

38ff15b src/sage/geometry/polyhedron/base.py: Add missing sage.rings.number_field

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 38ff15b to f2d72d3

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

f2d72d3 src/sage/geometry/polyhedron/parent.py: Remove unneeded import

mkoeppe commented 2 years ago

Changed dependencies from #32776, #32732 to #32776, #32732, #32174

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from f2d72d3 to 51ccab2

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

`7a81ba8`	`move lattice point methods to Polyhedron_base2`
`10dd56d`	`remove unused import`
`6a15f92`	`move combinatorics to Polyhedron_base3`
`f7d87e2`	`fix copy/paste-typo`
`6160076`	`Merge branch 'u/gh-kliem/polyhedron_base3' of git://trac.sagemath.org/sage into u/gh-kliem/polyhedron_base4-new`
`ff8c7ef`	`move methods relying on sage.graphs to Polyhedron_base4`
`51ccab2`	`Merge #32889`

mkoeppe commented 2 years ago

Changed dependencies from #32776, #32732, #32174 to #32776, #32732, #32174, #32889

mkoeppe commented 2 years ago

comment:16

messed up the merge

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 51ccab2 to 1c028c7

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1c028c7 Merge #32889

kliem commented 2 years ago

comment:19

LGTM.

kliem commented 2 years ago

Reviewer: Jonathan Kliem

mkoeppe commented 2 years ago

comment:20

Thanks!

vbraun commented 2 years ago

Changed branch from u/mkoeppe/sage_geometry_polyhedron__more___optional to 1c028c7

sagemath / sage

sage.geometry: More # optional #32846