Re-run bootstrap when an install-requires.txt or package-version.txt has changed

mkoeppe commented 2 years ago

Developers may see messages like the following when merging package upgrade tickets such as #32968.

Installing collected packages: Sphinx
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-apidoc to 755
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-autogen to 755
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-build to 755
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-quickstart to 755
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
sagemath-standard 9.5b9 requires sphinx<4.3,>=4, but you have sphinx 4.3.1 which is incompatible.
Successfully installed Sphinx-4.3.1

bootstrap generates various files (in the above, src/install-requires.txt) from the source files build/pkgs/*/install-requires.txt). To fix this, we should add these files as dependencies of the configure target in the top-level Makefile.

Likewise for the source files build/pkgs/*/package-version.txt, which influence other files such as src/requirements.txt that are generated by bootstrap.

Component: build

Author: Matthias Koeppe

Branch/Commit: 686fa78

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33115

mkoeppe commented 2 years ago

Branch: u/mkoeppe/re_run_bootstrap_when_an_install_requires_txt_has_changed

mkoeppe commented 2 years ago

New commits:

686fa78 Makefile (configure): Add dependencies on install-requires.txt and package-version.txt

mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -10,5 +10,8 @@
 sagemath-standard 9.5b9 requires sphinx<4.3,>=4, but you have sphinx 4.3.1 which is incompatible.
 Successfully installed Sphinx-4.3.1

+bootstrap generates various files (in the above, src/install-requires.txt) from the source files build/pkgs/*/install-requires.txt). To fix this, we should add these files as dependencies of the configure target in the top-level Makefile.

+Likewise for the source files build/pkgs/*/package-version.txt, which influence other files such as src/requirements.txt that are generated by bootstrap. +

mkoeppe commented 2 years ago

Commit: 686fa78

orlitzky commented 2 years ago

Reviewer: Michael Orlitzky

mkoeppe commented 2 years ago

comment:4

Thank you!

vbraun commented 2 years ago

Changed branch from u/mkoeppe/re_run_bootstrap_when_an_install_requires_txt_has_changed to 686fa78

sagemath / sage

Re-run bootstrap when an install-requires.txt or package-version.txt has changed #33115