sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 480 forks source link

Matplotlib update breaks build on debian buster #33143

Closed kliem closed 2 years ago

kliem commented 2 years ago

31580 or #33040 broke sage build on debian buster:

[matplotlib-3.5.1]   gcc -DNDEBUG -g -fwrapv -O2 -Wall -march=native -O3 -g -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DMPL_DEVNULL=/dev/null -DPY_ARRAY_UNIQUE_SYMBOL=MPL_matplotlib__$
hull_ARRAY_API -DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -D__STDC_FORMAT_MACROS=1 -I/srv/public/kliem/sage/local/var/lib/sage/venv-python3.7/lib/python3.7/site-packages/numpy/co$
e/include -I/srv/public/kliem/sage/local/var/lib/sage/venv-python3.7/include -I/usr/include/python3.7m -c src/qhull_wrap.cpp -o build/temp.linux-x86_64-3.7/matplotlib._qhull/src/q$
ull_wrap.o                                                                                                                                                                          
[matplotlib-3.5.1]   src/qhull_wrap.cpp:19:10: fatal error: libqhull_r/qhull_ra.h: No such file or directory                                                                        
[matplotlib-3.5.1]    #include "libqhull_r/qhull_ra.h"  

CC: @dimpase @kiwifb @mkoeppe @egourgoulhon

Component: build

Author: Matthias Koeppe

Branch/Commit: 9de0e06

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/33143

mkoeppe commented 2 years ago
comment:2

config.log please

kliem commented 2 years ago
comment:3

https://groups.google.com/g/sage-release/c/gTNMEVbzb6M/m/aZCzjiXMAQAJ

kiwifb commented 2 years ago
comment:4

Is qhull installed properly? The only thing I can think of otherwise is that the compilation line includes path to the venv but not to $SAGE_LOCAL/include where the library should be found.

mkoeppe commented 2 years ago
comment:5

Replying to @kliem:

https://groups.google.com/g/sage-release/c/gTNMEVbzb6M/m/aZCzjiXMAQAJ

From there:

configure:38313: checking for qhull
configure:38331: found /usr/bin/qhull
configure:38343: result: /usr/bin/qhull
configure:38359: checking is qhull's version good enough?
configure:38482: will use system package and not install SPKG qhull

Looks like build/pkgs/qhull/spkg-configure.m4 is missing the "else" branch in AX_COMPARE_VERSION

mkoeppe commented 2 years ago

Author: Matthias Koeppe

mkoeppe commented 2 years ago

Branch: u/mkoeppe/matplotlib_update_breaks_build_on_debian_buster

mkoeppe commented 2 years ago
comment:8

Try this please


New commits:

9de0e06build/pkgs/qhull/spkg-configure.m4: Fix test for library
mkoeppe commented 2 years ago

Commit: 9de0e06

kliem commented 2 years ago
comment:9

Thanks for the quick fix. This seems to be the problem.

kliem commented 2 years ago

Reviewer: Jonathan Kliem

vbraun commented 2 years ago

Changed branch from u/mkoeppe/matplotlib_update_breaks_build_on_debian_buster to 9de0e06