fix and activate pycodestyle E713

fchapoton commented 2 years ago

namely

E713 test for membership should be 'not in'

CC: @orlitzky

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: e29ec56

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33171

fchapoton commented 2 years ago

Commit: 8107605

fchapoton commented 2 years ago

Branch: u/chapoton/33171

fchapoton commented 2 years ago

New commits:

8107605 fix and activate pycodestyle E713

orlitzky commented 2 years ago

comment:2

I think this is fine but I'm always reluctant to force style preferences on other people, so maybe we should let it sit for a while to see if anyone objects.

fchapoton commented 2 years ago

comment:3

oh, well, if somebody is unhappy, it will be very easy to remove afterwards

orlitzky commented 2 years ago

Reviewer: Michael Orlitzky

orlitzky commented 2 years ago

comment:4

Ok, let's just do it. I think we're all used to using \notin anyway, and up to isomorphism this covered by PEP8 which says that x is not y is preferred to not x is y.

vbraun commented 2 years ago

comment:5

Merge failure on top of:

3e9c7ebd9c Trac #33167: Improve is_functional of lrs feature

75b2225f80 Trac #33159: wrong result solving equation system with symbolic matrix

b6cb6fb727 Trac #33158: kRegularSequence: minimization wrong

629bcd59cf Trac #33157: Use parent function, not method, to convert SR to RBF or CBF

e5f7680683 Trac #33154: random doctest failure in sage.plot.matrix_plot

4b81e72a97 Trac #33148: fix doctest in quantum_group_gap

dcc20a7359 Trac #33146: Replace imports from sage.*.all by more specific imports in combinat

8975e72de1 Trac #33142: remove doctest parsing of py2 long integers

7fa1231b5b Trac #33121: PARI/GP for elliptic curve discrete logarithms (elllog) and Weil pairings (ellweilpairing)

63a49bea94 Trac #33119: Remove deprecated things in geometry/polyhedron for sage-9.6

7c5436cc8c Trac #32999: Remove imports from sage.libs.all

5abb9e8404 Trac #32976: LLL, min, max, short_vectors for IntegralLattice

1e1263eb0f Trac #32801: Clean the use of weights in generic_graph.py - part 3

7d01de50a8 Trac #32800: Clean the use of weights in generic_graph.py - part 2

4bad770833 Trac #20343: Adding sage/plot/tikzpicture.py

51f7b326cf Trac #19951: Remove occurrences of trait_names

b41fb2fb18 Trac #33296: tox.ini: Add -recommended package factor

db7554fa67 Trac #33277: build/pkgs/_recommended/dependencies

5d2a381c37 Trac #33196: tox.ini: Add centos-stream-8, centos-stream-9, remove defunct centos-6

4fc783e6db Trac #33085: adjust dochtml label so doctests pass when html doc is not built/installed

45706f82b6 Trac #33033: Prepare sage.doctest for namespace packages

55fd5edb38 Trac #33027: zombie maxima process - if invoked from a script

b34c0d5ded Trac #31529: texlive: Add spkg-configure.m4 and system package information; remove install script

c4e4a6387f Trac #31415: GH Actions workflow that builds documentation on each push

9cc853b81b Trac #33107: Generic cholesky() fails on the trivial matrix

88a98d50c3 Trac #33103: gitpod integration using Docker images from portability testing workflow

d4466d825b Trac #33102: some details in shuffle and multizeta

09de266470 Trac #33098: Add more void packages to distros/void.txt

73dd8d1cf5 Trac #33096: src/tox.ini (relint): Exclude editor temp files etc.

a0d0888f54 Trac #33095: again some details in Dyck words

4fa191a754 Trac #33071: Update pillow to 8.4

733ed250a3 Trac #33070: Package upgrades for Python 3.10 support

e4f3f1dc9b Trac #33069: Remove spkg speaklater

18ba1d8cdd Trac #33064: sage_docbuild: fails when cache cannot be saved

467c32cce3 Trac #33049: Update scipy to 1.7.3

2cf334f97d Trac #33048: Update setuptools to 59.8.0

3a4cc169b4 Trac #33045: ffmpeg tests time out

8fb89a37bb Trac #33039: Random doctest failure in continued_fraction_gosper

236856d0da Trac #33026: make BinaryQF.solve_integer() work for square discriminants

2ad7305f87 Trac #33015: Random failure in number_field_element.pyx

c45f12e9e6 Trac #33009: Move is_prism and is_bipyramid to combinatorial polyhedron

87011e965e Trac #33008: Polyhedron_base.facet_adjacency_matrix: Do not use face_lattice

46cc022732 Trac #33007: Remove imports from sage.interfaces.all

57fe9e661a Trac #33005: Add feature for pdftocairo

69d9945eb0 Trac #32993: add pictures to line.py documentation

3834fded18 Trac #32788: Permanently get rid of bare except: statements

0207af8674 Trac #32209: Allow evaluation of morphisms of schemes on points over different rings

206ff0b058 Trac #33269: fix for build/pkgs/tox/distros/gentoo.txt

6d154b634f Trac #33226: Support giac-1.7.0.45 in doctests

d5d2e23df5 Trac #33187: Allow gcc/gfortran 12

59c0620436 Trac #33140: GH Actions (macOS): Fix filtering of experimental packages

0669c95412 Trac #32211: Upgrade FLINT to 2.8.4, arb to 2.22.1

508ea2d518 Trac #33284: Fix macro name clash introduced in #25633

b511685469 Trac #32989: Remove imports from sage.misc.all

9c6afb97c8 Trac #32505: Finitely presented graded modules over graded connected algebras

226937dfa9 Updated SageMath version to 9.6.beta0

merge was not clean: conflicts in src/tox.ini

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 8107605 to e29ec56

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

e29ec56 Merge branch 'u/chapoton/33171' in 9.6.b1

fchapoton commented 2 years ago

comment:7

setting back to positive after trivial rebase

vbraun commented 2 years ago

Changed branch from u/chapoton/33171 to e29ec56

sagemath / sage

fix and activate pycodestyle E713 #33171