MR54: Revisions to ring extension code

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.22k stars 424 forks source link

MR54: Revisions to ring extension code #33378

Open f588ca1e-f96a-4dea-804d-c55eab873dab opened 2 years ago

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

David Roe (@roed.math) opened a merge request at https://gitlab.com/sagemath/sage/-/merge_requests/54:

We were making enough changes to the ring extension code in support of relative finite fields and relative p-adic fields that we thought it would be best to separate it out (and add tests separately).

Component: algebra

Author: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/33378

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

Changed commit from 943c995 to 8899fb0

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

comment:1

New commits added to merge request. I updated the commit SHA-1. New commits:

`4332ca7`	`Renaming and deleting files in preparation for switching from Cython to Python`
`dc7088a`	`Removing obvious Cythonisms`
`ad8c74e`	`Some more fixes from Pythonization`
`8899fb0`	`Fixing some more cythonization problems`

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

Changed commit from 8899fb0 to 372949a

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

comment:2

New commits added to merge request. I updated the commit SHA-1. New commits:

`41a3a57`	`Fixing some tests`
`372949a`	`Removing some finite field changes`

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

comment:3

New commits added to merge request. I updated the commit SHA-1. New commits:

`52934e7`	`Fixing more tests`
`e478132`	`Fixing tests`

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

Changed commit from 372949a to e478132

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

Changed commit from e478132 to 527e55b

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

comment:4

New commits added to merge request. I updated the commit SHA-1. New commits:

`b0b96b1`	`Fix typos`
`6ff4453`	`Improve variable naming`
`1e495d1`	`Do not allow implicit creating of ring extension elements`
`527e55b`	`Disable numerator/denominator where we would have to rely on coercions from the backend`

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

comment:5

New commits added to merge request. I updated the commit SHA-1. New commits:

`8245ba6`	`Improve error messages of ring extensions`
`6f02802`	`Do not pass ignored gen keyword to ring extension factory`

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

Changed commit from 527e55b to 6f02802

tscrim commented 2 years ago

comment:6

It would be a nice while-we-are-at-it to also remove the periods/full-stops at the end of the INPUT: lines and have more of the documentation within 80 chars/line.

tscrim commented 2 years ago

Description changed:

kwankyu commented 2 years ago

comment:7

As the ticket #32627 is also about ring extensions, would someone here give me a convincing argument against the idea of the ticket? Here or on #32627.

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

Changed commit from 6f02802 to e195f49

f588ca1e-f96a-4dea-804d-c55eab873dab commented 2 years ago

comment:10

New commits added to merge request. I updated the commit SHA-1. New commits:

`5414749`	`Merge branch 'u/galois/mrs/55/unique-orders' of git://trac.sagemath.org/sage into ring-extension-revisions`
`8628c28`	`Working on fixing doctests`
`2edab96`	`Merge branch 'ring-extension-revisions' of gitlab.com:sagemath/dev/sage into ring-extension-revisions`
`e195f49`	`Working on getting tests to pass (still a ways to go)`

mkoeppe commented 1 year ago

Removed branch from issue description; replaced by PR #34991