Closed tscrim closed 2 years ago
An implementation of the Krawtchouk polynomials appear in coding/delsarte_bounds.py
. I am cc-ing those people as they might be interested (at least for consistency such as normalization differences and/or possible cross-references). This code is likely slower as it is more general but I haven't checked.
New commits:
9b5f2e1 | Cleanup functions/orthogonal_polys.py. |
6dca173 | Adding krawtchouk polynomials. |
cb7a54c | Adding Meixner polynomials; fixing some details with Krawtchouk. |
9399347 | Implement Hahn polynomials. |
Description changed:
---
+++
@@ -1 +1,3 @@
These are three classes of orthogonal polynomials in the Askey scheme. We should provide an implementation based on their definition as hypergeometric functions.
+
+This ticket provides just a basic implementation with no particular reason for the normalization choices.
the "eval_recursive" should be cached (in parent ?), don't you think ?
There isn't really a parent per se. Since the input could be widely varied, it doesn't make so much sense to cache it (and could quick eat up memory). There might be some benefit to caching the resulting (generic) polynomial, but this would likely need a bit of refactoring.
Description changed:
---
+++
@@ -1,3 +1,7 @@
-These are three classes of orthogonal polynomials in the Askey scheme. We should provide an implementation based on their definition as hypergeometric functions.
+These are three classes of orthogonal polynomials in
+the [Askey scheme](https://en.wikipedia.org/wiki/Askey_scheme).
+We should provide an implementation based on
+their definition as hypergeometric functions.
-This ticket provides just a basic implementation with no particular reason for the normalization choices.
+This ticket provides just a basic implementation with
+no particular reason for the normalization choices.
Branch pushed to git repo; I updated commit sha1. New commits:
b9f1eef | eval_recursive() is a method, not a function. |
This fixes the pyflakes issues reported by the otherwise green patchbot.
Branch pushed to git repo; I updated commit sha1. New commits:
2c45db3 | Some additional document improvements, including some more history. |
Patchbot is (morally) green.
ok
maybe one could add cross-references from and to the Krawtchouk polynomials in coding ?
Replying to @fchapoton:
ok
maybe one could add cross-references from and to the Krawtchouk polynomials in coding ?
perhaps on a follow-up ticket?
I think that is a good idea to have crossrefs. I have added them along with an explicit test checking the relationship between the conventions.
ok, thenl let's go
Reviewer: Frédéric Chapoton
Thank you.
[sagemath_doc_pdf-none] ?
[sagemath_doc_pdf-none] ! Emergency stop.
[sagemath_doc_pdf-none] ...
[sagemath_doc_pdf-none]
[sagemath_doc_pdf-none] l.4558 They are named after Pafnuty Chebyshev (Ч
[sagemath_doc_pdf-none] ебышёв 1821\sphinxhyp...
[sagemath_doc_pdf-none]
It looks like the pdf doc doesn’t like Cyrillic so much; I thought it would be fine with the Russian tutorial. Do you know how to get that to work? If not, then we can just remove it.
just remove cyrillic
Branch pushed to git repo; I updated commit sha1. New commits:
9b40ec4 | Remove Cyrillic from doc so pdf will compile. |
Removed.
did you check that pdf doc compiles ?
Yes, the pdf doc compiles for me.
Thanks, then let's move on
Changed branch from public/symbolics/more_orthogonal_polys-33393 to 9b40ec4
These are three classes of orthogonal polynomials in the Askey scheme. We should provide an implementation based on their definition as hypergeometric functions.
This ticket provides just a basic implementation with no particular reason for the normalization choices.
CC: @dimpase @sagetrac-tmonteil @ferihr @fchapoton @mezzarobba @slel
Component: symbolics
Keywords: orthogonal polynomials
Author: Travis Scrimshaw
Branch/Commit:
9b40ec4
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/33393