Closed kwankyu closed 2 years ago
Description changed:
---
+++
@@ -1 +1 @@
-
+We remove ugly `\(`, `\)`, `\` from the documentation title.
Branch: u/klee/33475
Branch pushed to git repo; I updated commit sha1. New commits:
f3d3fda | deTeX documentation title |
Commit: f3d3fda
It's much better this way, thank you. It's not perfect but it probably will never be without actually parsing the LaTeX: a page like https://doc.sagemath.org/html/en/reference/arithgroup/index.html will still end up with a title {rm SL}_2{{bf Z}}
. Actually it would be better if whoever originally wrote that had defined a macro \SL
and also used the existing macro \ZZ
.
In the big change in layout.html (when I view the branch here), is it a change in indentation or is there an actual difference in content?
Branch pushed to git repo; I updated commit sha1. New commits:
528ef65 | Use new commands \SL and \PSL |
Replying to @jhpalmieri:
It's much better this way, thank you. It's not perfect but it probably will never be without actually parsing the LaTeX.
Right.
a page like https://doc.sagemath.org/html/en/reference/arithgroup/index.html will still end up with a title
{rm SL}_2{{bf Z}}
. Actually it would be better if whoever originally wrote that had defined a macro\SL
and also used the existing macro\ZZ
.
While solving this, I ended up in adding new macros \SL
and \PSL
.
In the big change in layout.html (when I view the branch here), is it a change in indentation or is there an actual difference in content?
They are all just indentation changes to align them up.
Branch pushed to git repo; I updated commit sha1. New commits:
9187bf1 | Fix a glitch |
Branch pushed to git repo; I updated commit sha1. New commits:
eff36ec | Fix another glitch |
Branch pushed to git repo; I updated commit sha1. New commits:
fe4811c | Fix doctest failures |
Description changed:
---
+++
@@ -1 +1 @@
-We remove ugly `\(`, `\)`, `\` from the documentation title.
+We remove `\(`, `\)`, `\`, `$` from the documentation title.
Branch pushed to git repo; I updated commit sha1. New commits:
7285ad3 | Fix more doctest failures |
Branch pushed to git repo; I updated commit sha1. New commits:
11ed990 | Speed up macro parsing |
As before, I think it looks great. Do you want to keep tinkering, fixing small issues, or should we merge it and move on? By "small issues," I mean that if I visit the local version of https://doc.sagemath.org/html/en/reference/arithgroup/index.html, then the title bar says "Arithmetic Subgroups of SL_2(ZZ) — Arithmetic Subgroups of $SL_2(ZZ)$", and similarly when I follow links from that page. I don't know where the dollar signs are coming from, and I don't know if it's worth tracking down. (That's the only type of issue I've seen so far.)
Branch pushed to git repo; I updated commit sha1. New commits:
7da2b5f | Fix an error in removing $ |
Replying to @jhpalmieri:
As before, I think it looks great. Do you want to keep tinkering, fixing small issues, or should we merge it and move on? By "small issues," I mean that if I visit the local version of https://doc.sagemath.org/html/en/reference/arithgroup/index.html, then the title bar says "Arithmetic Subgroups of SL_2(ZZ) — Arithmetic Subgroups of $SL_2(ZZ)$", and similarly when I follow links from that page. I don't know where the dollar signs are coming from, and I don't know if it's worth tracking down. (That's the only type of issue I've seen so far.)
I don't know either. But those $
dollars should have been removed. The last commit would fix the error.
I have no more things to do. Thanks for reviewing.
Reviewer: John Palmieri
Great, thank you for fixing this!
Changed branch from u/klee/33475 to 7da2b5f
We remove
\(
,\)
,\
,$
from the documentation title.Component: documentation
Author: Kwankyu Lee
Branch/Commit:
7da2b5f
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/33475