sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 482 forks source link

./configure --enable-doc doesn't undo ./configure --disable-doc #33701

Closed orlitzky closed 2 years ago

orlitzky commented 2 years ago

After building sage with ./configure --disable-doc, running ./configure --enable-doc doesn't re-enable them.

$ make doc
...
make --no-print-directory pplpy_doc-SAGE_DOCS-no-deps
Error: The installation tree SAGE_DOCS has been disabled
This Sage build is configured with configure --disable-doc, so building the documentation will not work.

While config.log shows that I've explicitly enabled the docs:

$ head -n10 config.log 
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.

It was created by Sage configure 9.6.beta7, which was
generated by GNU Autoconf 2.71.  Invocation command line was

  $ ./configure --enable-download-from-upstream-url --disable-cvxopt --disable-notebook --disable-r --with-system-arb=force --with-system-boost_cropped=force --with-system-brial=force --with-system-bzip2=force --with-system-cddlib=force --with-system-cliquer=force --with-system-cmake=force --with-system-curl=force --with-system-ecl=force --with-system-eclib=force --with-system-fflas_ffpack=force --with-system-flint=force --with-system-fplll=force --with-system-gc=force --with-system-gcc=force --with-system-gengetopt=force --with-system-gf2x=force --with-system-gfan=force --with-system-gfortran=force --with-system-giac=force --with-system-git=force --with-system-givaro=force --with-system-gsl=force --with-system-iconv=force --with-system-iml=force --with-system-isl=force --with-system-lcalc=force --with-system-libatomic_ops=force --with-system-libbraiding=force --with-system-libffi=force --with-system-libgd=force --with-system-libhomfly=force --with-system-libnauty=force --with-system-libpng=force --with-system-linbox=force --with-system-lrcalc=force --with-system-m4ri=force --with-system-m4rie=force --with-system-mpfr=force --with-system-nauty=force --with-system-ncurses=force --with-system-ninja_build=force --with-system-ntl=force --with-system-openblas=force --with-system-pari=force --with-system-patch=force --with-system-perl_term_readline_gnu=force --with-system-planarity=force --with-system-ppl=force --with-system-primecount=force --with-system-primesieve=force --with-system-python3=force --with-system-qhull=force --with-system-readline=force --with-system-rw=force --with-system-singular=force --with-system-sqlite=force --with-system-suitesparse=force --with-system-symmetrica=force --with-system-sympow=force --with-system-tachyon=force --with-system-tox=force --with-system-xz=force --with-system-zeromq=force --with-system-zlib=force --enable-doc

## --------- ##
## Platform. ##

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 56c63db

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33701

mkoeppe commented 2 years ago
comment:1

Yes, the code in configure.ac forgets to check $enableval

mkoeppe commented 2 years ago

Author: Matthias Koeppe

mkoeppe commented 2 years ago

Branch: u/mkoeppe/configure___enable_doc_doesn_tundoconfigure___disable_doc

mkoeppe commented 2 years ago

New commits:

56c63dbconfigure.ac (--enable-doc): Fix
mkoeppe commented 2 years ago

Commit: 56c63db

orlitzky commented 2 years ago

Reviewer: Michael Orlitzky

orlitzky commented 2 years ago
comment:6

Yep, thanks.

vbraun commented 2 years ago

Changed branch from u/mkoeppe/configure___enable_doc_doesn_tundoconfigure___disable_doc to 56c63db