Closed JohnCremona closed 16 years ago
The code tries to compute in
Replying to @malb:
The code tries to compute in
- a local ordering "revlex" for which toy_buchberger.py is inadequat
- a ordering "revlex" which isn't really supported or misnamed, we do have "invlex"
malb: I am fixing this as part of a rewrite for division-polynomial related stuff, which will not need to use such things at all, so I don't think you need to worry about this (at least for now). John
This works for me:
mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.1.alpha2$ ./sage
----------------------------------------------------------------------
| SAGE Version 3.1.alpha1, Release Date: 2008-08-11 |
| Type notebook() for the GUI, and license() for information. |
----------------------------------------------------------------------
sage: E = EllipticCurve('19a1')
sage: K.<t> = NumberField(x^9-3*x^8-4*x^7+16*x^6-3*x^5-21*x^4+5*x^3+7*x^2-7*x+1)
sage: EK = E.base_extend(K)
sage: E(0).division_points(3)
[(0 : 1 : 0), (5 : -10 : 1), (5 : 9 : 1)]
sage: EK(0).division_points(3)
[(0 : 1 : 0), (5 : 9 : 1), (5 : -10 : 1)]
It works for me too. I think that something deep down changed, so now it just works.
It is still true that I am working on improving division poly stuff -- but on a clone which is on a machine currently broken, preventing me from finishing it off.
In the meantime, let's just close this.
Hi John,
Replying to @JohnCremona:
It works for me too. I think that something deep down changed, so now it just works.
It is still true that I am working on improving division poly stuff -- but on a clone which is on a machine currently broken, preventing me from finishing it off.
In the meantime, let's just close this.
I agree, but let's add a doctest to catch this in case someone breaks it again.
Cheers,
Michael
Replying to @sagetrac-mabshoff:
Hi John,
Replying to @JohnCremona:
It works for me too. I think that something deep down changed, so now it just works.
It is still true that I am working on improving division poly stuff -- but on a clone which is on a machine currently broken, preventing me from finishing it off.
In the meantime, let's just close this.
I agree, but let's add a doctest to catch this in case someone breaks it again.
Coming up...
John
Cheers,
Michael
Attachment: sage-trac3383.patch.gz
The patch just adds a doctest to show that the bug no longer exists.
Looks good to me and doctests fine. William also likes it.
Cheers,
Michael
Merged in Sage 3.1.alpha2
While testing/reviewing #3377 I found a problem with E.division_points() over a number field:
It looks quite deep in polynomial code but might turn out to be something simple.
Component: algebraic geometry
Issue created by migration from https://trac.sagemath.org/ticket/3383