sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.28k stars 438 forks source link

Replace SAGE_ROOT/sage by a symlink to src/bin/sage #33841

Open mkoeppe opened 2 years ago

mkoeppe commented 2 years ago

Now with the simplifications from #33786, #33787, were it not for the "relocate-once" code (which is only needed for Volker's binary packaging), we could just replace SAGE_ROOT/sage by a symlink to src/bin/sage (and add a fallback to determine SAGE_ROOT from $SELF there).

https://github.com/sagemath/binary-pkg (if anyone still wants to use it) could just replace the symlink by the custom script that runs relocate-once.

Depends on #33786 Depends on #33787

CC: @jhpalmieri @orlitzky

Component: scripts

Branch/Commit: u/mkoeppe/replace_sage_root_sage_by_a_symlink_to_src_bin_sage @ c100cc0

Issue created by migration from https://trac.sagemath.org/ticket/33841

mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-Now with this simplification, were it not for the "relocate-once" code (which is only needed for Volker's binary packaging), we can just replace `SAGE_ROOT/sage` by a symlink to `src/bin/sage`.
+Now with the simplifications from #33786, #33787, were it not for the "relocate-once" code (which is only needed for Volker's binary packaging), we could just replace `SAGE_ROOT/sage` by a symlink to `src/bin/sage`.

 https://github.com/sagemath/binary-pkg
 could just replace the symlink by the custom script that runs relocate-once.
mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,5 +1,5 @@
 Now with the simplifications from #33786, #33787, were it not for the "relocate-once" code (which is only needed for Volker's binary packaging), we could just replace `SAGE_ROOT/sage` by a symlink to `src/bin/sage`.

-https://github.com/sagemath/binary-pkg
+https://github.com/sagemath/binary-pkg (if anyone still wants to use it) 
 could just replace the symlink by the custom script that runs relocate-once.
mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-Now with the simplifications from #33786, #33787, were it not for the "relocate-once" code (which is only needed for Volker's binary packaging), we could just replace `SAGE_ROOT/sage` by a symlink to `src/bin/sage`.
+Now with the simplifications from #33786, #33787, were it not for the "relocate-once" code (which is only needed for Volker's binary packaging), we could just replace `SAGE_ROOT/sage` by a symlink to `src/bin/sage` (and add a fallback to determine `SAGE_ROOT` from `$SELF` there).

 https://github.com/sagemath/binary-pkg (if anyone still wants to use it) 
 could just replace the symlink by the custom script that runs relocate-once.
mkoeppe commented 2 years ago

Branch: u/mkoeppe/replace_sage_root_sage_by_a_symlink_to_src_bin_sage

mkoeppe commented 2 years ago

Commit: c100cc0

mkoeppe commented 2 years ago
comment:5

Not sure if this is really an improvement, but it's a simplification of sorts.


New commits:

60bcbecREADME.md, src/doc/en/installation/source.rst: Update multi-user install
2116f9fREADME.md: Update final step 'symlink sage', add jupyter kernel step
5c68335Merge #33787
252372dSAGE_ROOT/sage: Unconditionally determine SAGE_ROOT from $0; no longer invite to edit this file
01caa38SAGE_ROOT/sage: Actually unconditionally determine SAGE_ROOT from $0
5c60b07Merge #33786
59877bdMakefile (micro_release): Fix typo in comment
e537bf3sage: Remove outdated check for SAGE_ROOT/local/bin/sage
4c9b00bMerge #33787
c100cc0SAGE_ROOT/sage: Replace by symlink to src/bin/sage, handle unconfigured case there