sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 481 forks source link

Dummy package _sagemath: record downstream package of Sage in distributions #33870

Closed mkoeppe closed 2 years ago

mkoeppe commented 2 years ago

To generate info for src/doc/en/installation/linux.rst and to provision devcontainers that launch downstream Sage as packaged by distributions (as done in #33671 for archlinux, conda)

Depends on #34252

CC: @antonio-rojas @kiwifb @isuruf @collares @tornaria @tobihan @jhpalmieri @seblabbe @nbruin @kwankyu

Component: documentation

Author: Matthias Koeppe

Branch/Commit: 4280369

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/33870

mkoeppe commented 2 years ago

Branch: u/mkoeppe/dummy_script_packagesagemathrecord_downstream_package_of_sage_in_distributions

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Commit: fc06250

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fc06250build/pkgs/_sagemath: New
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from fc06250 to a2557d4

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

a2557d4build/pkgs/_sagemath/distros/debian.txt: Move debian info here from src/doc/en/installation/linux.rst
mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-To generate info in `src/doc/en/installation/linux.rst`
+To generate info for `src/doc/en/installation/linux.rst`
 and to provision devcontainers that launch downstream Sage as packaged by distributions (as done in #33671 for archlinux, conda)
mkoeppe commented 2 years ago
comment:4

I have taken the information about the packages from repology; please help to make this information accurate

Also https://trac.sagemath.org/wiki/Distribution#Packagemanagers probably needs updating - I've come across some broken links etc.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from a2557d4 to 3dd0d18

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3dd0d18build/pkgs/_sagemath/type: New
mkoeppe commented 2 years ago

Author: Matthias Koeppe, ...

mkoeppe commented 2 years ago

Changed author from Matthias Koeppe, ... to Matthias Koeppe

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

9d1e07aRevive furo
f19b597Add link to the logo
09d5f5cFix the logo link for reference
ae75d53Fix a subtle reference problem for build_options
3519bedRun docbuild workflow with single thread
1274718Fix a suspicious part of categories doc
e5b1f7eAdd search.html
ebd3b77Better pygments style
73e5aa3Make white logo transparent to match with furo
05d909cMerge #34252
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 3dd0d18 to 05d909c

mkoeppe commented 2 years ago

Dependencies: #34252

kwankyu commented 2 years ago
comment:11
diff --git a/build/pkgs/_sagemath/SPKG.rst b/build/pkgs/_sagemath/SPKG.rst
index c0021422ad..5f38af716d 100644
--- a/build/pkgs/_sagemath/SPKG.rst
+++ b/build/pkgs/_sagemath/SPKG.rst
@@ -12,4 +12,4 @@ including documentation and Jupyter.
 Downstream Contact
 ------------------

-See https://trac.sagemath.org/wiki/Distribution#Packagemanagers
+See :trac:`wiki/Distribution#Packagemanagers`.
kwankyu commented 2 years ago
comment:12

Before the above change, there was an error in building the documentation. But with the above change, it shows as

See trac ticket #wiki/Distribution#Packagemanagers.
mkoeppe commented 2 years ago
comment:13

Somewhere else we use

:trac:`Trac wiki page Distribution <wiki/Distribution>`

I'll change it to that.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7cc2e57build/pkgs/_sagemath/SPKG.rst: Fix markup of trac wiki link
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 05d909c to 7cc2e57

kwankyu commented 2 years ago
comment:15

These "dummy script packages" might be of type "dummy" so that they are not mixed with real standard and optional packages.

kwankyu commented 2 years ago
comment:16

Please leave "dependencies" blank instead of "none". It will look better.

kwankyu commented 2 years ago
comment:17

Could a dummy package be really installable? Specifically, how about "_recommended" package?

mkoeppe commented 2 years ago
comment:18

The word "None" is generated by build/bin/sage-spkg-info. Do you suggest I should change that and leave the "Dependencies" section blank in general in this case?

mkoeppe commented 2 years ago
comment:19

No, dummy packages are not installable. That's what makes them dummy. _recommended is not installable either

kwankyu commented 2 years ago
comment:20

Then the type of a dummy package is not significant?

kwankyu commented 2 years ago
comment:21

Replying to @mkoeppe:

The word "None" is generated by build/bin/sage-spkg-info. Do you suggest I should change that and leave the "Dependencies" section blank in general in this case?

For documentation look and feel, yes. But if you think "None" is better for other considerations, then I would not insist.

mkoeppe commented 2 years ago
comment:22

The output is only about look and feel. I'll change it.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

3392763build/bin/sage-spkg-info: Do not print 'None' when there are no dependencies
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 7cc2e57 to 3392763

mkoeppe commented 2 years ago
comment:24

Replying to @kwankyu:

Then the type of a dummy package is not significant?

I think they are all "optional", there's no additional distinction

kwankyu commented 2 years ago
comment:25

Replying to @kwankyu:

These "dummy script packages" might be of type "dummy" so that they are not mixed with real standard and optional packages.

Just an idea for another ticket...

mkoeppe commented 2 years ago
comment:26

I'd say "dummy script" is a "source type", not a "package type", see https://doc.sagemath.org/html/en/developer/packaging.html#package-source-types

mkoeppe commented 2 years ago
comment:27

Replying to @mkoeppe:

Replying to @kwankyu:

Then the type of a dummy package is not significant?

I think they are all "optional", there's no additional distinction

Except for _prereq, which is a standard dummy script package.

kwankyu commented 2 years ago
comment:28

Replying to @mkoeppe:

I'd say "dummy script" is a "source type", not a "package type", see https://doc.sagemath.org/html/en/developer/packaging.html#package-source-types

But "dummy package" is a package type.

More seriously it seems that the last two lines are also auto-generated, and not suitable for a dummy package.

...
nix:

$ nix-env --install sage
void:

$ sudo xbps-install  sagemath
See https://repology.org/project/sagemath/versions

However, these system packages will not be used for building Sage 
because spkg-configure.m4 has not been written for this package; see trac ticket #27330

So these dummy packages really should be treated separately. But for this, later.

There is a typo:

See <../reference/spkg/index.html>`_ for the names of packages ...

Missing apostrophe?

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 3392763 to ef7732f

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

ef7732fsrc/doc/en/installation/linux.rst: Fix markup
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

6bf421esrc/doc/en/developer/packaging.rst: Explain dummy packages
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from ef7732f to 6bf421e

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 6bf421e to 4280369

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

4280369Change 'dummy script package' to just 'dummy package'
kwankyu commented 2 years ago
comment:32

Thanks for updating stuffs for dummy packages.

It looks good to me.

kwankyu commented 2 years ago

Reviewer: Kwankyu Lee

mkoeppe commented 2 years ago
comment:34

Thank you!

vbraun commented 2 years ago

Changed branch from u/mkoeppe/dummy_script_packagesagemathrecord_downstream_package_of_sage_in_distributions to 4280369