sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.39k stars 472 forks source link

failing doctest involving polymake and number field #33930

Closed edd8e884-f507-429a-b577-5d554626c0fe closed 2 years ago

edd8e884-f507-429a-b577-5d554626c0fe commented 2 years ago

With polymake installed, on 9.6, there is an doctest error, probably due to some change in "number field" not taken into account with polymake not installed:

sagemath@debian:/opt/sagemath/sage-9.6$ ./sage -t --long --random-seed=220977816658885637174790555079465548143 src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst
Running doctests with ID 2022-05-28-15-25-39-5ef555c5.
Git branch: develop
Using --optional=4ti2,barvinok,benzene,bliss,buckygen,ccache,coxeter3,cryptominisat,csdp,cunningham_tables,cylp,d3js,debian,debugpy,dot2tex,e_antic,fricas,frobby,gap_jupyter,gap_packages,glucose,igraph,info,jupymake,kenzo,latte_int,libogg,libsemigroups,lidia,mathics,mathics_scanner,mcqd,meataxe,mpfrcx,normaliz,notedown,palettable,pandoc_attributes,pari_elldata,pari_galpol,pari_jupyter,pari_nftables,pari_seadata,pint,pip,plantri,polylib,polymake,pycosat,pycryptosat,pynormaliz,pysingular,python_igraph,rst2ipynb,rubiks,saclib,sage,sage_numerical_backends_coin,sage_spkg,singular_jupyter,sip,sirocco,symengine,symengine_py,tdlib,texttable,tides,topcom
Features to be detected: 4ti2,benzene,bliss,buckygen,conway_polynomials,csdp,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_jones_numfield,database_knotinfo,dvipng,gfan,graphviz,imagemagick,jupymake,kenzo,latte_int,lrslib,mcqd,meataxe,nauty,palp,pandoc,pdf2svg,pdftocairo,phitigra,plantri,polytopes_db,polytopes_db_4d,pynormaliz,python_igraph,rubiks,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.plot,sage.rings.number_field,sage.rings.padics,sage.rings.real_double,sage.symbolic,sage_numerical_backends_coin,sagemath_doc_html,sphinx,tdlib
Doctesting 1 file.
sage -t --long --warn-long 60.1 --random-seed=220977816658885637174790555079465548143 src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst
**********************************************************************
File "src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst", line 659, in doc.en.thematic_tutorials.geometry.polyhedra_tutorial
Failed example:
    Polyhedron(vertices=V, backend='polymake')               # optional - polymake  # optional - sage.rings.number_field
Expected:
    A 3-dimensional polyhedron
     in (Number Field in sqrt5 with defining polynomial x^2 - 5)^3
     defined as the convex hull of 20 vertices
Got:
    A 3-dimensional polyhedron in (Number Field in sqrt5 with defining polynomial x^2 - 5 with sqrt5 = 2.236067977499790?)^3 defined as the convex hull of 20 vertices
**********************************************************************
1 item had failures:
   1 of 115 in doc.en.thematic_tutorials.geometry.polyhedra_tutorial
    [114 tests, 1 failure, 18.29 s]
----------------------------------------------------------------------
sage -t --long --warn-long 60.1 --random-seed=220977816658885637174790555079465548143 src/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 18.8 seconds
    cpu time: 17.2 seconds
    cumulative wall time: 18.3 seconds
Features detected for doctesting: sage.rings.number_field,sage.symbolic

Component: packages: optional

Keywords: sdl

Author: Thierry Monteil

Branch/Commit: 1720e60

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33930

edd8e884-f507-429a-b577-5d554626c0fe commented 2 years ago

Branch: u/tmonteil/failing_doctest_involving_polymake_and_number_field

edd8e884-f507-429a-b577-5d554626c0fe commented 2 years ago

Author: Thierry Monteil

edd8e884-f507-429a-b577-5d554626c0fe commented 2 years ago

Commit: 5fb2a6e

mkoeppe commented 2 years ago
comment:3

the branch is not right

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 5fb2a6e to 1720e60

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

1720e60#33930 : fix doctest for polyhedra_tutorial.rst
edd8e884-f507-429a-b577-5d554626c0fe commented 2 years ago
comment:6

Sorry for the noise.

mkoeppe commented 2 years ago

Reviewer: Matthias Koeppe

vbraun commented 2 years ago

Changed branch from u/tmonteil/failing_doctest_involving_polymake_and_number_field to 1720e60