changes about avoiding double dieses

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.44k stars 480 forks source link

Closed fchapoton closed 2 years ago

fchapoton commented 2 years ago

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 36b45fa

Reviewer: David Coudert

fchapoton commented 2 years ago

Commit: 8aabf99

fchapoton commented 2 years ago

New commits:

8aabf99 bunch of changes about not using double dieses

fchapoton commented 2 years ago

dcoudert commented 2 years ago

comment:2

You could also fix

src/sage/topology/simplicial_complex.py:2370:37 import 'chain' from line 177 shadowed by loop variable

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

36b45fa a few more fixes in simplicial_complex.py

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 8aabf99 to 36b45fa

fchapoton commented 2 years ago

comment:4

voila, avec deux trois autres détails dans le meme fichier

dcoudert commented 2 years ago

Reviewer: David Coudert

dcoudert commented 2 years ago

comment:5

Perfect. LGTM.

vbraun commented 2 years ago

Changed branch from u/chapoton/34057 to 36b45fa