search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.34k stars 454 forks source link

pycodestyle cleanup in 5 files of src/sage/graphs/ #34075

Closed dcoudert closed 2 years ago

dcoudert commented 2 years ago

We clean:

It remains only

sage/graphs/graph_latex.py:366:161: E501 line too long (199 > 160 characters)
sage/graphs/graph_latex.py:367:161: E501 line too long (177 > 160 characters)

which are due to a doctest of the module.

Component: graph theory

Author: David Coudert

Branch/Commit: 7c4d823

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/34075

dcoudert commented 2 years ago

Branch: public/graphs/34075

dcoudert commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,4 +1,14 @@
 We clean:
 - `bipartite_graph.py`
 - `digraph_generators.py`
+- `domination.py`
+- `dot2tex_utils.py`
+- `graph_latex.py`

+It remains only
+
+```
+sage/graphs/graph_latex.py:366:161: E501 line too long (199 > 160 characters)
+sage/graphs/graph_latex.py:367:161: E501 line too long (177 > 160 characters)
+```
+which are due to a doctest of the module.
dcoudert commented 2 years ago

New commits:

fc8db8atrac #34075: cleanup bipartite_graph.py and digraph_generators.py
6409feftrac #34075: cleanup domination.py
546e83ctrac #34075: cleanup dot2tex_utils.py
65aa3cdtrac #34075: cleanup graph_latex.py
dcoudert commented 2 years ago

Commit: 65aa3cd

kwankyu commented 2 years ago
comment:2

LGTM.

kwankyu commented 2 years ago

Reviewer: Kwankyu Lee

vbraun commented 2 years ago
comment:3

Merge failure on top of:

691239d449 Trac #34073: pycodestyle cleanup in src/sage/graphs/graph_coloring.pyx

061241f24b Trac #34068: pycodestyle cleanup in src/sage/graphs/connectivity.pyx

65b834a993 Trac #33971: Height of a dynamical system is wrong

385b628ef7 Trac #22857: Using symbolic variables in domain 'positive' makes Sage crash

cc6a8fb370 Trac #10980: Make sure symbolic gridline values are okay

1a32d02790 Trac #34227: Compute the similarity class type of a given matrix; compute invariant subspace generating function from similarity class type

1f9fbb8fca Trac #34218: Implement longest_increasing_subsequence_number

d55f18bd80 Trac #34216: configure: Use --with-system-{gfortran,openssl,python3}=force on Cygwin

ffa1104f58 Trac #34214: Faster version of longest_increasing_subsequence_length

4c250eb283 Trac #34208: Remove package sip

e8caec9232 Trac #34200: Add importlib_metadata to Sphinx's dependencies

195b7578eb Trac #34189: Remove imports from sage.all and sage.rings.all in sage.rings

8117fe9e0f Trac #34187: Remove src/sage/init.py

99e0db84b0 Trac #34177: Update setuptools to 63.2.0

22e1027795 Trac #34176: update curl to version 7.84

68c736c3c9 Trac #33817: GH Actions: Add test of the modularized distributions

6b7bed7c35 Trac #32406: Make "./configure --enable-editable" the default

2c1e4a1a1b Trac #31568: Add commands "sage --lldb", "sage -t --lldb"

96b57ea0f5 Trac #31451: Faster version of longest_increasing_subsequences

991429de56 Trac #34115: tox.yml: Refactor using reusable workflows, update Linux platforms

05a53e3c45 Trac #33627: Remove sage-gdb-commands from src/bin

c17e6377ce Trac #22349: Deprecate sorting of Graph vertices and edges by default

c19c47fd63 Trac #34174: insufficient precision in scaling elliptic curves over number fields by units

aa8a4647f9 Trac #34172: Fix docstring markup in sage/groups and sage/misc

4142099591 Trac #34168: Fix docstring markup in sage/categories

e9be1728bb Trac #34166: Fix docstring markup in sage/tests except sage/tests/book_stein_modform.py

6e41b53b09 Trac #34164: Fix docstring markup in sage/plot and sage/graphs

b03229e112 Trac #34163: Fix docstring markup in sage/interfaces

46849b8d41 Trac #34160: Fix docstring markup in sage/schemes

984137bbb8 Trac #34155: OpenSSL 3.0.5 security update

ced8f29e11 Trac #34151: get rid of Oops messages in quadratic forms

b0456638af Trac #34149: make documentation building compatible with sphinx 5

07d4b909f0 Trac #34105: ZeroDivisionError while reducing a polynomial w.r.t. the zero ideal

db21903ace Trac #33798: Implement the Links-Gould polynomial invariant for links

04ad7f9577 Trac #33705: "make doc-clean" should remove inventory, doctrees

977e691dc1 Trac #33636: replace loadable_module_extension() by importlib.machinery.EXTENSION_SUFFIXES

c744d7c09c Trac #29097: build/make/Makefile.in: Rename make targets SPKG-clean to SPKG-uninstall

8312ee1e90 Trac #33530: Upgrade ipython to 8.x

067a66c7e9 Trac #33428: prompt_toolkit 3.0.25+ breaks Ctrl-C

79ed9e5ddb Trac #33160: update Singular to 4.3.1

4cc4817aeb Trac #32088: gfan testsuite hangs on 32bit

10247d5f2a Trac #31049: "setup.py develop" rewrites the installed sage-version.sh as if it is a Python script

7f7149489c Updated SageMath version to 9.7.beta6

merge was not clean: conflicts in src/sage/graphs/digraph_generators.py

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

7c4d823trac #34075: fix merge conflict with 9.7.beta8
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 65aa3cd to 7c4d823

dcoudert commented 2 years ago
comment:5

I fixed merge conflict due to #22349. I set the ticket back to positive.

kwankyu commented 2 years ago
comment:6

Okay. Looks good.

vbraun commented 2 years ago

Changed branch from public/graphs/34075 to 7c4d823