search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.29k stars 443 forks source link

Doctest failure with nauty-gentreeg #34133

Open mkoeppe opened 2 years ago

mkoeppe commented 2 years ago

with system nauty 2.6r7+ds-1 on debian-stretch (https://github.com/sagemath/sage/runs/7243040063?check_suite_focus=true)

The interface and doctest were added in #33670

CC: @dcoudert @dimpase

Component: graph theory

Issue created by migration from https://trac.sagemath.org/ticket/34133

mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 with system nauty on debian-stretch (https://github.com/sagemath/sage/runs/7243040063?check_suite_focus=true)

-
+The interface and doctest were added in #33670
mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
-with system nauty on debian-stretch (https://github.com/sagemath/sage/runs/7243040063?check_suite_focus=true)
+with system nauty 2.6r7+ds-1 on debian-stretch (https://github.com/sagemath/sage/runs/7243040063?check_suite_focus=true)

 The interface and doctest were added in #33670
mkoeppe commented 2 years ago
comment:2

No failure on debian-buster-standard with system nauty 2.6r10+ds-1

dcoudert commented 2 years ago
comment:3

I have no clue what's happening here.

dimpase commented 2 years ago
comment:4

debian stretch is past EOL (and past LTS support too). Are we dropping it? https://wiki.debian.org/LTS

mkoeppe commented 2 years ago
comment:5

Replying to @dcoudert:

I have no clue what's happening here.

This system can be inspected using docker run -it docker.pkg.github.com/sagemath/sage/sage-docker-debian-stretch-standard-with-targets-optional:9.7.beta4 ./sage

mkoeppe commented 2 years ago
comment:6

Replying to @dimpase:

debian stretch is past EOL (and past LTS support too). Are we dropping it? https://wiki.debian.org/LTS

I don't think there's any urgency to drop it. I'd prefer that we detect bad nauty versions in configure

dcoudert commented 1 year ago

This issue is similar to #35157. The only solution I see is to be more restrictive on version numbers.

GMS103 commented 1 year ago

This issue is similar to #35157. The only solution I see is to be more restrictive on version numbers.

How can that be done? I have tried modifying $SAGE_ROOT/build/pkgs/nauty/spkg-configure.m4 (which seems a bit old) using PKG_CHECK_MODULES with >= and < without success (but then I am only a novice).

dcoudert commented 1 year ago

I don't know how to modify this file. May be Matthias can help ?

GMS103 commented 1 year ago

Thanks to Dima, Homebrew's nauty has been patched and now it works (but the test files must be updated).

GMS103 commented 1 year ago

For other people arriving here, I quote Dima:

Actually, one can patch 2.8.6, as reported by upstream: https://mailman.anu.edu.au/pipermail/nauty/2023-January.txt

tornaria commented 1 year ago

This seems a dupe of #35157. The doctest failures for a patched nauty 2.8.6 are addressed by #35250 but checking system nauty for the bug at configure time is still open (I won't work on that since I'm no longer using sage-the-distro).

dcoudert commented 6 months ago

Do we still have this issue after the last update of nauty (#36774) ?