sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.45k stars 482 forks source link

handle range of parameters in nauty-genbg interface #34179

Closed maxale closed 2 years ago

maxale commented 2 years ago

nauty-genbg has inherent limitation for the ranges of partite set sizes, and produces an error if they are out of these ranges - like:

$ nauty-genbg 5 28
>E genbg: must have n1=1..24, n1+n2=1..32

I believe this is a major but poorly documented limitation. It'd be nice if the recently added interface (ticket #33365) take a special care of it and communicated such an error (if it appears) clearly to the user.

I'm not sure if the interface should really check any ranges itself as the allowed range may potentially change in future versions of nauty-genbg.

Component: graph theory

Author: David Coudert

Branch/Commit: 1733d84

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/34179

dcoudert commented 2 years ago

Commit: 1733d84

dcoudert commented 2 years ago
comment:1

The range of parameters n1 and n2 is now documented. Let me know if this is ok for you.


New commits:

1733d84trac #34179: document range of vertices in each class
dcoudert commented 2 years ago

Author: David Coudert

dcoudert commented 2 years ago

Branch: public/graphs/34179_genbg

fchapoton commented 2 years ago
comment:3

ok, looks good enough

fchapoton commented 2 years ago

Reviewer: Frédéric Chapoton

vbraun commented 2 years ago

Changed branch from public/graphs/34179_genbg to 1733d84