sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.29k stars 443 forks source link

Arborescence packing with Gabow DFS #34230

Open 264c63e9-79e4-426c-ab2d-7ce38c7c4a27 opened 2 years ago

264c63e9-79e4-426c-ab2d-7ce38c7c4a27 commented 2 years ago

Expansion of graphs module edge connectivity to include packing arborescences.

CC: @dcoudert

Component: graph theory

Keywords: GSoC2022

Author: Georgia Channing

Branch/Commit: public/graphs/34230_arborescence_packing_with_gabow_dfs @ 0e93fe6

Issue created by migration from https://trac.sagemath.org/ticket/34230

dcoudert commented 2 years ago

Changed dependencies from #33839 to none

dcoudert commented 2 years ago
comment:1

Since #33839 has been merged in 9.7.beta6, we don't need the dependency.

264c63e9-79e4-426c-ab2d-7ce38c7c4a27 commented 2 years ago

Branch: /public/graphs/34230_arbor

264c63e9-79e4-426c-ab2d-7ce38c7c4a27 commented 2 years ago

Changed branch from /public/graphs/34230_arbor to none

264c63e9-79e4-426c-ab2d-7ce38c7c4a27 commented 2 years ago

Branch: public/graphs/34230_arborescence_packing_with_gabow_dfs

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Commit: ec29d54

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

fd4ba5cinfrastructure for packing gabow dfs
ec29d54infrastructure for packing arborescences
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from ec29d54 to 11d4e1c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

b742c7cbuild out period step and find tree
11d4e1c80%+ implemented
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Changed commit from 11d4e1c to 378989c

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Branch pushed to git repo; I updated commit sha1. New commits:

51713fftuesday 11:46 pm
db9fe28tuesday 11:46 pm
378989cwriting to trac, 95% but still not compiling
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Changed commit from 378989c to 5efa917

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Branch pushed to git repo; I updated commit sha1. New commits:

79939e4trac #34230: Merged with 9.7.rc0
5efa917trac #34230: less compilation errors
dcoudert commented 1 year ago
comment:10

I did a few edits to reduce the number of compilation errors. However I cannot do more yet as for several variables, I don't know what's the goal of the variables, what it should contain (e.g., array A), it's expected size (e.g., root_size is used as a 2 dimensional array but was defined as one dimensional array. The second dimension must be initialized).

So please add more useful comments. May be some variables should be vectors and not arrays, etc.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

aee14a4stashing
5314800testing with deletions
c919631moving enjeck
e2de4cbit compiles
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Changed commit from 5efa917 to e2de4cb

dcoudert commented 1 year ago
comment:12

The good news is that you are able to compile ;)

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Branch pushed to git repo; I updated commit sha1. New commits:

e7ecb76doc strings
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Changed commit from e2de4cb to e7ecb76

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Changed commit from e7ecb76 to 44b3612

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Branch pushed to git repo; I updated commit sha1. New commits:

44b3612new dfs, but no g minus a
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Branch pushed to git repo; I updated commit sha1. New commits:

0e93fe6remove copy
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Changed commit from 44b3612 to 0e93fe6