search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

SimplicialComplex: Add method is_subcomplex #34294

Closed mkoeppe closed 2 years ago

mkoeppe commented 2 years ago

... in analogy to cubical and polyhedral complexes

(from #33586)

CC: @yuan-zhou @jhpalmieri

Component: geometry

Author: John Palmieri

Branch/Commit: a597465

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34294

jhpalmieri commented 2 years ago

Branch: u/jhpalmieri/simplicial_complex_is_subcomplex

jhpalmieri commented 2 years ago

Author: John Palmieri

jhpalmieri commented 2 years ago

Commit: a597465

jhpalmieri commented 2 years ago
comment:2

How about this?

New commits:

a597465trac 34294: is_subcomplex method for simplicial complexes
mkoeppe commented 2 years ago

Reviewer: Matthias Koeppe

mkoeppe commented 2 years ago
comment:3

Great! LGTM

jhpalmieri commented 2 years ago
comment:4

Thanks!

vbraun commented 2 years ago

Changed branch from u/jhpalmieri/simplicial_complex_is_subcomplex to a597465