sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

README.md, installation guide: Mention cocalc Docker image instead of sagemath/sagemath image #34367

Closed mkoeppe closed 2 years ago

mkoeppe commented 2 years ago

The sagemath/sagemath image has been broken and semi-abandoned for a long time. We replace mentions of it by the cocalc image and a link to https://trac.sagemath.org/wiki/Distribution#Dockerimages

CC: @saraedum @videlec @williamstein @kwankyu @slel @dimpase

Component: docker

Author: Matthias Koeppe

Branch/Commit: 551df02

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34367

mkoeppe commented 2 years ago

Branch: u/mkoeppe/readme_md__mention_cocalc_docker_image_instead_of_sagemath_sagemath_image

mkoeppe commented 2 years ago

New commits:

4aaedd7README.md, src/doc/en/installation/index.rst: Mention sagemathinc/cocalc instead of sagemath/sagemath
mkoeppe commented 2 years ago

Commit: 4aaedd7

mkoeppe commented 2 years ago

Author: Matthias Koeppe

saraedum commented 2 years ago
comment:3

I agree that the sagemath image is essentially abandoned. I manage to upgrade it sometimes but it always requires me to fix some breakage that was introduced in the latest release. (And nobody else seems to be willing to help with this.)

I wouldn't call the image broken though. The sagemath-dev image takes forever to start since the latest upgrade but the the normal sagemath image should work fine though being outdated. At the same time the cocalc image is 6GB and I imagine that many people look for such images for CI purposes. (The sagemath image has unfortunately jumped to 1.5GB with its latest upgrade...)

So, shouldn't we mention both or rather link to a wiki page so the instructions can be easily adapted?

saraedum commented 2 years ago
comment:4

(I hope you don't mind me downgrading this to critical. It's been an issue for a while so I don't think this should be considered blocking for 9.7.)

mkoeppe commented 2 years ago
comment:5

Sure, we can link to https://trac.sagemath.org/wiki/Distribution#Dockerimages instead.

mkoeppe commented 2 years ago
comment:6

But then we need to update that page to no longer recommend the sagemath, sagemath-dev images.

saraedum commented 2 years ago
comment:7

Replying to @mkoeppe:

But then we need to update that page to no longer recommend the sagemath, sagemath-dev images.

Yes, let's link to that wiki page instead.

I don't see why we should not recommend the sagemath image. It should work fine (though it's only 9.5.)

williamstein commented 2 years ago
comment:8

Thumbs up from me :-). I regularly maintain and update cocalc-docker, and plan to continue to do so longterm. It also gets a lot of usage and people complain when it breaks.

I sometimes build aarch64 images as well, though not as often as I would like.

mkoeppe commented 2 years ago
comment:9

Replying to @saraedum:

I don't see why we should not recommend the sagemath image. It should work fine (though it's only 9.5.)

Because it's sending potential Sage users to a dead end, and this is what we must avoid.

It's outdated (both Sage and the OS). There's no working way to upgrade it. Can't install optional packages (there's no make, can't install make) etc.

mkoeppe commented 2 years ago
comment:10

Julian, please don't get me wrong. You have been doing a great service for the Sage community by developing and maintaining this Docker image. It's just that currently I don't think we can recommend it to anyone.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 4aaedd7 to 9cfeebe

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

9cfeebeREADME.md: Be clearer that README only contains build-from-source instructions; remove section on Docker
7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 9cfeebe to 6212abf

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

6212abfsrc/doc/en/installation/index.rst: Also link to https://trac.sagemath.org/wiki/Distribution\#Dockerimages
mkoeppe commented 2 years ago
comment:13

Ready for review

mkoeppe commented 2 years ago

Description changed:

--- 
+++ 
@@ -1,2 +1 @@
-The sagemath/sagemath image has been broken and semi-abandoned for a long time. We replace mentions of it by the cocalc image.
-
+The sagemath/sagemath image has been broken and semi-abandoned for a long time. We replace mentions of it by the cocalc image and a link to https://trac.sagemath.org/wiki/Distribution#Dockerimages
mkoeppe commented 2 years ago
comment:16

I've edited https://trac.sagemath.org/wiki/Distribution#Dockerimages to include a list of open tickets and a call for maintainers for sagemath/sagemath. Please feel free to edit!

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 6212abf to 551df02

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1. New commits:

551df02src/doc/en/installation/index.rst: Fix markup of trac wiki link
mkoeppe commented 2 years ago
comment:18

The documentation builds now, let's please get it in.

dimpase commented 2 years ago

Reviewer: Dima Pasechnik

dimpase commented 2 years ago
comment:20

lgtm

mkoeppe commented 2 years ago
comment:21

Thanks!

vbraun commented 2 years ago

Changed branch from u/mkoeppe/readme_md__mention_cocalc_docker_image_instead_of_sagemath_sagemath_image to 551df02