remove rings from streams

mantepse commented 2 years ago

Currently, Stream_function and Stream_map_coefficient depend on a ring argument, which seems unnecessary, and which we therefore remove.

Depends on #34413

CC: @tscrim

Component: combinatorics

Keywords: LazyPowerSeries

Author: Martin Rubey

Branch/Commit: f69c2de

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34473

mantepse commented 2 years ago

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+Currently, `Stream_function` and `Stream_map_coefficient` depend on a ring argument, which seems unnecessary, and which we therefore remove.

mantepse commented 2 years ago

Changed keywords from none to LazyPowerSeries

mantepse commented 2 years ago

Author: Martin Rubey

mantepse commented 2 years ago

Dependencies: #34413

mantepse commented 2 years ago

Branch: u/mantepse/remove_rings_from_streams

mantepse commented 2 years ago

Commit: 6010361

mantepse commented 2 years ago

Last 10 new commits:

`6745cf1`	`Some last details and optimizations to Stream_plethysm.`
`3d6d39f`	`fix typo in comment`
`ee35418`	`Merge branch 'public/rings/lazy_series_revert-34383' of trac.sagemath.org:sage into t/34413/implement_derivatives_of_lazy_series`
`dafdcb4`	`fix doctests`
`9124987`	`Merge branch 'public/rings/lazy_series_revert-34383' of trac.sagemath.org:sage into t/34413/implement_derivatives_of_lazy_series`
`610078f`	`add doctests`
`731072a`	`remove unnecessary code leftover from merge, and remove unneccesary import detected by pyflakes`
`5666eae`	`Merge branch 'public/rings/lazy_series_revert-34383' of trac.sagemath.org:sage into t/34413/implement_derivatives_of_lazy_series`
`e1e7f0d`	`Merge branch 'u/mantepse/implement_derivatives_of_lazy_series' of trac.sagemath.org:sage into t/34473/remove_rings_from_streams`
`6010361`	`remove ring argument from Stream_map_coefficient and Stream_function`

tscrim commented 2 years ago

comment:4

Green bot => positive review.

tscrim commented 2 years ago

Reviewer: Travis Scrimshaw

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`1729827`	`Merge branch 'u/mantepse/implement_derivatives_of_lazy_series' of https://github.com/sagemath/sagetrac-mirror into u/tscrim/derivatives_lazy_series-34413`
`5d76825`	`Merge branch 'u/chapoton/34494' of https://github.com/sagemath/sagetrac-mirror into u/tscrim/derivatives_lazy_series-34413`
`97df300`	`Updating sf/sfa.py doctest due to #34494.`
`1388b8a`	`Merge branch 'u/chapoton/34494' of https://github.com/sagemath/sagetrac-mirror into public/rings/lazy_series_revert-34383`
`7bfe5f7`	`Merge branch 'public/rings/lazy_series_revert-34383' of https://github.com/sagemath/sagetrac-mirror into public/rings/lazy_series_revert-34383`
`2039990`	`Updating doctest due to changes from #34494.`
`cdea820`	`Merge branch 'public/rings/lazy_series_revert-34383' of https://github.com/sagemath/sagetrac-mirror into u/tscrim/derivatives_lazy_series-34413`
`b7f04ed`	`Merge branch 'develop' of trac.sagemath.org:sage into t/34413/derivatives_lazy_series-34413`
`f69c2de`	`Merge branch 'u/mantepse/derivatives_lazy_series-34413' of trac.sagemath.org:sage into t/34473/remove_rings_from_streams`

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 2 years ago

Changed commit from 6010361 to f69c2de

mantepse commented 2 years ago

comment:7

trivial (automatic) merge, necessary to make the patchbots happy.

vbraun commented 2 years ago

Changed branch from u/mantepse/remove_rings_from_streams to f69c2de

sagemath / sage

remove rings from streams #34473