sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.33k stars 453 forks source link

rename example to QuaternionicProjectivePlane #34568

Closed fchapoton closed 1 year ago

fchapoton commented 1 year ago

as this has been proved by Gorodkov in 2016 to be indeed the projective plane over H

https://arxiv.org/abs/1603.05541

CC: @jhpalmieri

Component: algebraic topology

Author: Frédéric Chapoton

Branch/Commit: ae5676b

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/34568

fchapoton commented 1 year ago

Branch: u/chapoton/34568

fchapoton commented 1 year ago

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 as this has been proved by Gorodkov in 2016 to be indeed the projective plane over H
+
+https://arxiv.org/abs/1603.05541
fchapoton commented 1 year ago

New commits:

9548409change name of example in simplicial complexes
fchapoton commented 1 year ago

Commit: 9548409

fchapoton commented 1 year ago
comment:2

should be an easy review ; I am not sure it is worth deprecating the old name

jhpalmieri commented 1 year ago
comment:3

Thank you for discovering Gorodkov's result! The deprecation question is the only thing worth worrying about. It would be safest to deprecate the name, and then follow up pretty quickly and delete it. (I feel like some of our deprecation warnings linger for a while, but this one should definitely be short-lived.)

I could also be convinced that we don't need to deprecate it but just delete it. I do not expect that there are many people using this in their code, and it is easy to find the new command.

fchapoton commented 1 year ago
comment:4

Yes, it is indeed a nice result. I have learned that from a recent talk of Gaifullin, that has just found a minimal triangulation of OP2.

https://arxiv.org/abs/2207.08507

Well, maybe one could just put a deprecated alias in the catalog of examples. Putting an alias for a short time is not really an option, as the rule is to wait one year after the next release after the ticket.

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Changed commit from 9548409 to ae5676b

7ed8c4ca-6d56-4ae9-953a-41e42b4ed313 commented 1 year ago

Branch pushed to git repo; I updated commit sha1. New commits:

ae5676badding a deprecation
jhpalmieri commented 1 year ago
comment:6

Looks good to me. Docs build and tests pass.

jhpalmieri commented 1 year ago

Reviewer: John Palmieri

vbraun commented 1 year ago

Changed branch from u/chapoton/34568 to ae5676b