`sage.misc.dist`: Remove; deprecated in #30207 (2022)

sagemath / sage

Main repository of SageMath. Now open for Issues and Pull Requests.

https://www.sagemath.org

Other

1.08k stars 394 forks source link

`sage.misc.dist`: Remove; deprecated in #30207 (2022) #37856

Closed mkoeppe closed 1 week ago

mkoeppe commented 2 weeks ago

Deprecated in:

30207 (2022)

:memo: Checklist

[x] The title is concise and informative.
[ ] The description explains in detail what this PR is about.
[x] I have linked a relevant issue or discussion.
[ ] I have created tests covering the changes.
[ ] I have updated the documentation and checked the documentation preview.

:hourglass: Dependencies

github-actions[bot] commented 2 weeks ago

Documentation preview for this PR (built with commit 5a8b125de7d4e8ecde3d1991f6d8ff7240a31c6c; changes) is ready! :tada: This preview will update shortly after each push to this PR.

jhpalmieri commented 2 weeks ago

Looks good to me.

mkoeppe commented 2 weeks ago

Thank you!

soehms commented 4 hours ago

This broke our docker/Dockerfile for Docker Hub (see this workflow run) in line 234:

# Put scripts to start gap, gp, maxima, ... in /usr/bin
RUN sudo $SAGE_ROOT/sage --nodotsage -c "install_scripts('/usr/bin')"

Can I just delete these two lines or must they be replaced by something else?

mkoeppe commented 3 hours ago

Sorry about missing this! Perhaps $SAGE_ROOT/local/bin should just be prepended to PATH in this image.