`src/bin/sage-env`: Set fewer variables - Githubissues

sagemath / sage

Main repository of SageMath. Now open for Issues and Pull Requests.

https://www.sagemath.org

Other

1.08k stars 394 forks source link

`src/bin/sage-env`: Set fewer variables #37862

Open mkoeppe opened 2 weeks ago

mkoeppe commented 2 weeks ago

Inspired by https://groups.google.com/g/sage-devel/c/4s_5HmznHZM @culler @tornaria

git --no-pager grep -E '[$][{(]?(CP|MV|RANLIB|LN|MKDIR|CHMOD|TOUCH|AR)[^A-Z]' shows very few uses of these variables; likely these are leftovers that supported SPKG scripts that have long been replaced, or support for platforms long forgotten.
likewise git --no-pager grep -E '[$][{(]?(AS|LD)[^A-Z_]' (the appearance in lie is unrelated)

Also removing the problematic setting of CXXFLAGS (when empty or unset) from a nonemptyCFLAGS.

:memo: Checklist

[x] The title is concise and informative.
[x] The description explains in detail what this PR is about.
[x] I have linked a relevant issue or discussion.
[ ] I have created tests covering the changes.
[ ] I have updated the documentation and checked the documentation preview.

:hourglass: Dependencies

github-actions[bot] commented 2 weeks ago

Documentation preview for this PR (built with commit ed3877a25f5dbbe3267a4dc68992dc22e7216fed; changes) is ready! :tada: This preview will update shortly after each push to this PR.