LPDictionary: Make it safe to copy dictionaries - Githubissues

sagemath / sage

Main repository of SageMath. Now open for Issues and Pull Requests.

https://www.sagemath.org

Other

1.08k stars 394 forks source link

LPDictionary: Make it safe to copy dictionaries #37866

Open mkoeppe opened 2 weeks ago

mkoeppe commented 2 weeks ago

Dictionaries are mutable, and copying them using copy results in dictionaries that share internal objects, which causes unwelcome surprises.

rebased from #31308

Author: @mkoeppe, @ComboProblem

Fixes #31308.

:memo: Checklist

[x] The title is concise and informative.
[ ] The description explains in detail what this PR is about.
[x] I have linked a relevant issue or discussion.
[ ] I have created tests covering the changes.
[ ] I have updated the documentation and checked the documentation preview.

:hourglass: Dependencies

github-actions[bot] commented 2 weeks ago

Documentation preview for this PR (built with commit 2589af6436d64fb2b1df40481d5a8623c06efaa2; changes) is ready! :tada: This preview will update shortly after each push to this PR.