search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.33k stars 453 forks source link

allow Rust-based standard packages as platform-dependent wheel - how about the rest? #38475

Open dimpase opened 1 month ago

dimpase commented 1 month ago

We have had a bitter fight over whether standard packages can be binary wheel packages, which was my proposal for e.g. pytest.

This is not even mentioned in #38219 - and these working on #38219 were against my proposal. I would like to know what happened and why such a change of heart?

Originally posted by @kwankyu in https://github.com/sagemath/sage/issues/38219#issuecomment-2219371509

dimpase commented 1 month ago

marked #38219 as disputed - as this has been discussed, as a part of my proposal on sage-devel, and rejected. Now it is resurrected without any credit to me and to these discussions.

kwankyu commented 3 weeks ago

Would you review #38219? You may use #38551 specifically created for those who are blocked from the PR.

If you have objections, please express them in a way that the author may respond. Being explicit may help.

Sorry for your inconvenience.

dimpase commented 3 weeks ago

Unfortunately the author seems to completely ignore anything I do, so this looks like a waste of time.

dimpase commented 3 weeks ago

I have marked #38219 as "needs work"

dimpase commented 3 weeks ago

  1. the credits are not given

  2. pip has functionality to deal with hashes for binary wheels, but the PR appears to do something else, and it looks as an unnecessary complexity being added