sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.43k stars 478 forks source link

FareySymbol fundamental_domain function cannot set thickness #38582

Open hooyuser opened 2 months ago

hooyuser commented 2 months ago

Steps To Reproduce

Expected Behavior

The thickness of line for both hyperbolic_triangle and hyperbolic_arc are set to 0.1.

Actual Behavior

Only the thickness of line for hyperbolic_arc are set to 0.1. See the image below.

sage_bug

Additional Information

c.f. https://github.com/sagemath/sage/blob/develop/src/sage/modular/arithgroup/farey_symbol.pyx#L900 According to the source code, g.set_aspect_ratio(1) means aspect ratio should be set to 1 by default. However, I found print(F.aspect_ratio()) gives result automatic. And I have to set it manually by F.set_aspect_ratio(1) to get the correct aspect ratio.

Environment

Checklist

hgranath commented 1 month ago

Would it help to add the keyword argument thickness=options['thickness'] to these lines?