search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.44k stars 480 forks source link

build/pkgs/sagetex: missing dependency on $(PYTHON_TOOLCHAIN) ? #38657

Closed orlitzky closed 1 month ago

orlitzky commented 1 month ago

It needs python_build, which is part of PYTHON_TOOLCHAIN, though maybe there's a better answer:

[sagetex-3.6.1] No stamp file for package 'sagetex' in /home/mjo/src/sage.git/local/var/lib/sage/venv-python3.12/var/lib/sage/installed
[sagetex-3.6.1] No spkg-legacy-uninstall script; nothing to do
[sagetex-3.6.1] [spkg-install] Installing sagetex-3.6.1
[sagetex-3.6.1] [spkg-install] /home/mjo/src/sage.git/local/var/lib/sage/venv-python3.12/bin/python3: No module named build
[sagetex-3.6.1] [spkg-install] Warning: building with "python3 -m build --wheel --outdir=dist   ." failed.
[sagetex-3.6.1] [spkg-install] Retrying with "python3 -m build --wheel --outdir=dist --no-isolation --skip-dependency-check  .".
[sagetex-3.6.1] [spkg-install] /home/mjo/src/sage.git/local/var/lib/sage/venv-python3.12/bin/python3: No module named build
[sagetex-3.6.1] [spkg-install] ********************************************************************************
[sagetex-3.6.1] [spkg-install] Error building a wheel for sagetex-3.6.1
[sagetex-3.6.1] [spkg-install] ********************************************************************************
orlitzky commented 1 month ago

@mkoeppe I could certainly fix this but I see a commit by you changing $(PYTHON_TOOLCHAIN) to pip?

mkoeppe commented 1 month ago

Wheel packages only need pip, not the whole tool chain.

Sent from my phone

On Sat, Sep 21, 2024 at 14:39 Michael Orlitzky @.***> wrote:

@mkoeppe https://github.com/mkoeppe I could certainly fix this but I see a commit by you changing $(PYTHON_TOOLCHAIN) to pip?

— Reply to this email directly, view it on GitHub https://github.com/sagemath/sage/issues/38657#issuecomment-2365313487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7VNBNOPG4A2SOKM76E2PTZXXKRBAVCNFSM6AAAAABOGIJ6ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGMYTGNBYG4 . You are receiving this because you were mentioned.Message ID: @.***>

mkoeppe commented 1 month ago

... but of course sagetex is not a wheel package. So adding $(PYTHON_TOOLCHAIN) is the correct fix. PR please?

orlitzky commented 1 month ago

It looks like https://github.com/sagemath/sage/pull/38752 is going in. Closing this now so I don't forget.