sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.47k stars 487 forks source link

A few outrageously long tests #38827

Open orlitzky opened 1 month ago

orlitzky commented 1 month ago

Edit: deleted the first one which isn't reproducible in CPU time

Silver This took less time than the third place finisher but the "(5 seconds)" comment is worth extra points.

File "src/sage/schemes/curves/projective_curve.py", line 1403, in sage.schemes.curves.projective_curve.ProjectivePlaneCurve.ordinary_model
Warning, slow doctest:
    C.ordinary_model() # long time (5 seconds)
Test ran for 974.65 s, check ran for 0.00 s

And with CPU time (on a different machine):

File "src/sage/schemes/curves/projective_curve.py", line 1403, in sage.schemes.curves.projective_curve.ProjectivePlaneCurve.ordinary_model
Warning, slow doctest:
    C.ordinary_model() # long time (5 seconds)
Test ran for 428.86s cpu, 429.53s wall
Check ran for 0.00s cpu, 0.00s wall
    [498 tests, 551.92s wall]

Bronze

File "src/sage/schemes/cyclic_covers/cycliccover_finite_field.py", line 1140, in sage.schemes.cyclic_covers.cycliccover_finite_field.CyclicCover_finite_field.frobenius_polynomial
Warning, slow doctest:
    CyclicCover(3, h).frobenius_polynomial()  # long time
Test ran for 1046.50 s, check ran for 0.00 s

And with CPU time (on a different machine):

File "src/sage/schemes/cyclic_covers/cycliccover_finite_field.py", line 1140, in sage.schemes.cyclic_covers.cycliccover_finite_field.CyclicCover_finite_field.frobenius_polynomial
Warning, slow doctest:
    CyclicCover(3, h).frobenius_polynomial()  # long time
Test ran for 248.93s cpu, 250.58s wall
Check ran for 0.00s cpu, 0.00s wall
mantepse commented 1 month ago

Could it be that there is a performance regression?

orlitzky commented 1 month ago

The main problem is that we aren't measuring how long the tests take in a meaningful way, but that will hopefully be fixed soon in https://github.com/sagemath/sage/pull/36226

I don't think there was a regression, I think they were always this slow.