sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.47k stars 485 forks source link

Add missing long time tag to a failing doctest #38891

Closed kwankyu closed 3 weeks ago

kwankyu commented 3 weeks ago

To fix

sage -t --warn-long 5.0 --random-seed=279311403945742486210819617974441498089 src/sage/parallel/map_reduce.py
**********************************************************************
File "src/sage/parallel/map_reduce.py", line 1145, in sage.parallel.map_reduce.RESetMapReduce.start_workers
Failed example:
    S.finish()
Exception raised:
    Traceback (most recent call last):
      File "/Users/kwankyu/GitHub/sage-dev/src/sage/doctest/forker.py", line 715, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/kwankyu/GitHub/sage-dev/src/sage/doctest/forker.py", line 1136, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.parallel.map_reduce.RESetMapReduce.start_workers[4]>", line 1, in <module>
        S.finish()
      File "/Users/kwankyu/GitHub/sage-dev/src/sage/parallel/map_reduce.py", line 1239, in finish
        worker.join()
      File "/usr/local/Cellar/python@3.12/3.12.7/Frameworks/Python.framework/Versions/3.12/lib/python3.12/multiprocessing/process.py", line 148, in join
        assert self._popen is not None, 'can only join a started process'
               ^^^^^^^^^^^^^^^^^^^^^^^
    AssertionError: can only join a started process
**********************************************************************

:memo: Checklist

:hourglass: Dependencies

github-actions[bot] commented 3 weeks ago

Documentation preview for this PR (built with commit 5fc36068d1c2a529ee9995f8a08985ffcd8214c8; changes) is ready! :tada: This preview will update shortly after each push to this PR.

tornaria commented 3 weeks ago

Duplicate of #38873 ?

kwankyu commented 3 weeks ago

A bit different solution for the same problem. I think the fix of this PR is more to the point.

Reviewer may choose a better one.

kwankyu commented 3 weeks ago

Ah, it already got positive review. OK. I will close this one.