remove the last use of PrincipalIdealDomain

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.46k stars 482 forks source link

remove the last use of PrincipalIdealDomain #38922

Closed fchapoton closed 6 days ago

fchapoton commented 2 weeks ago

This is removing the last use of the auld class PrincipalIdealDomain

:memo: Checklist

[x] The title is concise and informative.
[x] The description explains in detail what this PR is about.
[ ] I have linked a relevant issue or discussion.
[ ] I have created tests covering the changes.
[ ] I have updated the documentation and checked the documentation preview.

vincentmacri commented 2 weeks ago

If this class isn't used anymore, can the class itself be deleted entirely? It looks like it's already deprecated.

github-actions[bot] commented 2 weeks ago

Documentation preview for this PR (built with commit e798f08d869af76a45084d6e467974b7727da40d; changes) is ready! :tada: This preview will update shortly after each push to this PR.

fchapoton commented 2 weeks ago

I has only be deprecated formally recently. We have to wait one year after the first release after the deprecation.