Overwrote methods concerning loops for a matching covered graph

janmenjayap commented 2 weeks ago

The objective of this issue is to overwrite the methods pertaining to loops for a matching covered graph.

More specifically, this PR aims to implement/ update the following methods:

[x] allow_loops(): Change whether loops are allowed in (matching covered) graphs.
[x] allows_loops(): Return whether loops are permitted in (matching covered) graphs.
[x] has_loops(): Check whether thare are loops in the (matching covered) graph.
[x] loop_edges(): Return a list of all loops in the (matching covered) graph.
[x] loop_vertices(): Return a list of vertices with loops.
[x] loops(): Return a list of all loops in the (matching covered) graph.
[x] number_of_loops(): Return the number of edges that are loops.
[x] remove_loops(): Remove loops on vertices in vertices.

This PR shall address the methods related to loops for matching covered graphs.

Fixes #38216. Note that this issue fixes a small part of the mentioned issue. This PR depends on the PR #38742.

:memo: Checklist

[x] The title is concise and informative.
[x] The description explains in detail what this PR is about.
[x] I have linked a relevant issue or discussion.
[x] I have created tests covering the changes.
[x] I have updated the documentation and checked the documentation preview.

:hourglass: Dependencies

Nothing as of now (up to my knowledge).

cc: @dcoudert.

janmenjayap commented 2 weeks ago

I think you added too many doctests. Do we really need to tests all the methods in the tests of all methods ?

Oh. I will rectify this.

github-actions[bot] commented 2 weeks ago

Documentation preview for this PR (built with commit 91c97b475524df4a4760ce10785957978f29bac5; changes) is ready! :tada: This preview will update shortly after each push to this PR.

janmenjayap commented 1 week ago

Hi, If I am not mistaken, shouldn't we wait till the PR #38742 is merged followed by resolving the conflicts in this PR after pulling the changes from develop branch?

dcoudert commented 1 week ago

Yes, it would be much better. I'm setting back this PR to needs review then.

sagemath / sage

Overwrote methods concerning loops for a matching covered graph #38955

:memo: Checklist

:hourglass: Dependencies