search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.46k stars 482 forks source link

Disallow scaling of quaternion fractional ideals by zero #38963

Closed S17A05 closed 6 days ago

S17A05 commented 1 week ago

This PR disallows the scaling of quaternion fractional ideals by the zero element of the surrounding quaternion algebra (throwing a ValueError in the process), as the result will by definition not be a fractional ideal. It also adds additional checks to avoid scaling by zero in other tests, which came up in the issue mentioned below, and it adds a missing warning for a long doctest.

Fixes #38947.

github-actions[bot] commented 1 week ago

Documentation preview for this PR (built with commit ae698fbf121fc73fa9b33156769dbf00f94af286; changes) is ready! :tada: This preview will update shortly after each push to this PR.