Do not allow order of AbelianGroup generator to be negative

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.46k stars 482 forks source link

Do not allow order of AbelianGroup generator to be negative #38970

Open DaveWitteMorris opened 1 week ago

DaveWitteMorris commented 1 week ago

Fixes #38967.

Revised the _normalize method of Multiplicative Abelian Groups to raise an error if any of the generators are specified to have negative order. Also added a doctest.

:memo: Checklist

[x] The title is concise and informative.
[x] The description explains in detail what this PR is about.
[x] I have linked a relevant issue or discussion.
[x] I have created tests covering the changes.
[x] I have updated the documentation and checked the documentation preview.

github-actions[bot] commented 1 week ago

Documentation preview for this PR (built with commit cf4fe6ff5a6810589733c536823f44e1c80161d4; changes) is ready! :tada: This preview will update shortly after each push to this PR.

DaveWitteMorris commented 6 days ago

Thanks for the review!