search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.46k stars 482 forks source link

Fix build of meataxe extension with meson #38972

Open antonio-rojas opened 6 days ago

antonio-rojas commented 6 days ago

meataxe is not a library, the library is called mtx and is already searched for

antonio-rojas commented 6 days ago

tdlib and mcqd are also not found because they are header-only, so find_library doesn't work.

github-actions[bot] commented 6 days ago

Documentation preview for this PR (built with commit 46892d468b0d31c95fe5d527fe935c4d6913783d; changes) is ready! :tada: This preview will update shortly after each push to this PR.

tobiasdiez commented 5 days ago

tdlib and mcqd are also not found because they are header-only, so find_library doesn't work.

They also don't seem to provide pkg-config info. So just using cc.has_header to check for the required headers, and if then set the dependency object to disabler() if not found?

antonio-rojas commented 5 days ago

tdlib and mcqd are also not found because they are header-only, so find_library doesn't work.

They also don't seem to provide pkg-config info. So just using cc.has_header to check for the required headers, and if then set the dependency object to disabler() if not found?

Done in https://github.com/sagemath/sage/pull/38984

antonio-rojas commented 5 days ago

Setting back to positive review, it was a simple rebase