search

sagemath / sage

Main repository of SageMath
https://www.sagemath.org
Other
1.47k stars 485 forks source link

[postitive review] Update eclib to eclib-20080310.p6.spkg #4191

Closed JohnCremona closed 16 years ago

JohnCremona commented 16 years ago

I applied the patch supplied by Arnaud Bergeron to use ${MAKE} instead of make. At the same time I changed one line in src/g0n/Makefile, adding ecnf to PROGS since otherwise that binary was being left behind after "make veryclean".

I seem to remember that mabshoff said that the effect would be negligible since my Makefiles use gnu-isms anyway, but here it is.

See also #3358.

I just checked that this installs ok on a fresh 3.1.3.alpha1 build. A fresh spkg is attached.

Component: packages: standard

Keywords: eclib

Issue created by migration from https://trac.sagemath.org/ticket/4191

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 16 years ago
comment:2

John,

please do not attach spkgs since the trac install (and all attachments) are backed up daily and a 1.5mb spkg is rather large. So I have deleted the spkg and it is now at

http://sage.math.washington.edu/home/mabshoff/eclib-20080310.p6.spkg

Cheers,

Michael

JohnCremona commented 16 years ago
comment:3

Replying to @sagetrac-mabshoff:

John,

please do not attach spkgs since the trac install (and all attachments) are backed up daily and a 1.5mb spkg is rather large. So I have deleted the spkg and it is now at

http://sage.math.washington.edu/home/mabshoff/eclib-20080310.p6.spkg

Cheers,

Michael

Very sorry, I knew I would do something wrong. Next time I'll just put it somewhere and put in a link. Now I have a sagemath account that will be easier.

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 16 years ago
comment:4

Everything looks good. I deleted on stray SPKG.txt~ from the main directory. Positive review.

Cheers,

Michael

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 16 years ago
comment:5

Merged in Sage 3.1.3.alpha2

fchapoton commented 1 year ago

Description changed:

--- 
+++ 
@@ -1,6 +1,6 @@
 I applied the patch supplied by Arnaud Bergeron to use ${MAKE} instead of make.  At the same time I changed one line in src/g0n/Makefile, adding ecnf to PROGS since otherwise that binary was being left behind after "make veryclean".

-I seem to remember that mabsoff said that the effect would be negligible since my Makefiles use gnu-isms anyway, but here it is.
+I seem to remember that mabshoff said that the effect would be negligible since my Makefiles use gnu-isms anyway, but here it is.

 See also #3358.