polish the new symbolic logic code.

sagemath / sage

Main repository of SageMath

https://www.sagemath.org

Other

1.34k stars 454 forks source link

polish the new symbolic logic code. #545

Closed williamstein closed 15 years ago

williamstein commented 17 years ago

This is a single commit bundle, so if somebody could extract the patch and post it here it would be a good idea.

Cheers,

Michael

Component: basic arithmetic

Keywords: editor_wstein

Issue created by migration from https://trac.sagemath.org/ticket/545

a8806e44-c4d4-4baf-918e-1f2679b05e2d commented 15 years ago

comment:47

In the class BooleanFormula there is a spelling mistake in a function name, "equivlant" instead of equivalent. The same mistake is repeated a few times in the documentation.

a8806e44-c4d4-4baf-918e-1f2679b05e2d commented 15 years ago

fix spelling mistakes

4ecb6cfd-27aa-477a-80a8-c49e29e5d355 commented 15 years ago

Attachment: equivlant.patch.gz

Attachment: trac_545-equivlant_rebased.patch.gz

apply after the other five patches instead of "equivlant.patch"

4ecb6cfd-27aa-477a-80a8-c49e29e5d355 commented 15 years ago

comment:48

Minh, thanks for your good work! After applying the five patches Minh mentioned in the correct order to Sage-3.4.2.alpha0, the equivlant.patch didn't apply. So I rebased and made it such that Wilfried's name appears in it as originator.

Positive review to the sequence of five patches Minh mentioned. And positive review to the changes of Wilfried (I really did nothing but rebase them). The main author here is Chris Gorecki, of course.

After this ticket is finally closed (Requiescat In Pacem), the next steps would be to dismiss "logic.py" (I think it becomes mostly obsolete by this patch here), add the "rest" as a logic chapter to the Sphinx documentation (probably this needs some work, but hopefully some scripts will be available to help), and finally work on/solve #5910.

Cheers, gsw

85eec1a4-3d04-4b4d-b711-d4db03337c41 commented 15 years ago

comment:49

Merged

trac_545-logic5.patch
trac_545-latex2.patch
trac_545_long-doctests-fixed.patch
trac_545_boolformula-doctests.patch
trac_545-adjust-simplify.patch
trac_545-equivlant_rebased.patch

in Sage 3.4.2.rc0. Note that there are some odd whitespace issues in those files, so if someone could take care of that at #5910 it would be splendid :)

Cheers,

Michael